Chromium Code Reviews

Unified Diff: slave/skia_slave_scripts/run_gm.py

Issue 295753002: upload SKP renderings that did not match expectations (Closed) Base URL: https://skia.googlesource.com/buildbot.git@master
Patch Set: update comment about Google Storage ACLs Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Index: slave/skia_slave_scripts/run_gm.py
diff --git a/slave/skia_slave_scripts/run_gm.py b/slave/skia_slave_scripts/run_gm.py
index 97efda9bbe686b2dfc68b64c7499b865e472df84..d5eb6e8aa747724fa787f67a64d60dbab2fefb19 100644
--- a/slave/skia_slave_scripts/run_gm.py
+++ b/slave/skia_slave_scripts/run_gm.py
@@ -7,7 +7,6 @@
from build_step import BuildStep
import build_step
-import os
import sys
@@ -20,16 +19,16 @@ class RunGM(BuildStep):
timeout=timeout, no_output_timeout=no_output_timeout, **kwargs)
def _Run(self):
- output_dir = os.path.join(self._device_dirs.GMActualDir(),
- self._builder_name)
+ output_dir = self._flavor_utils.DevicePathJoin(
+ self._device_dirs.GMActualDir(), self._builder_name)
cmd = ['--verbose',
'--writeChecksumBasedFilenames',
# Don't bother writing out image files that match our expectations--
# we know that previous runs have already uploaded those!
'--mismatchPath', output_dir,
'--missingExpectationsPath', output_dir,
- '--writeJsonSummaryPath', os.path.join(output_dir,
- JSON_SUMMARY_FILENAME),
+ '--writeJsonSummaryPath', self._flavor_utils.DevicePathJoin(
+ output_dir, JSON_SUMMARY_FILENAME),
'--ignoreErrorTypes',
'IntentionallySkipped', 'MissingExpectations',
'ExpectationsMismatch',

Powered by Google App Engine