slave/skia_slave_scripts/build_step.py - Issue 295753002: upload SKP renderings that did not match expectations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: slave/skia_slave_scripts/build_step.py

Issue 295753002: upload SKP renderings that did not match expectations (Closed) Base URL: https://skia.googlesource.com/buildbot.git@master

Patch Set: update comment about Google Storage ACLs Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: slave/skia_slave_scripts/build_step.py

diff --git a/slave/skia_slave_scripts/build_step.py b/slave/skia_slave_scripts/build_step.py

index 5339a8520542b8601527c2f386bdc5ec5b095834..18a3ac354be4db1262aa28b2f357f2a01284d4b2 100644

--- a/slave/skia_slave_scripts/build_step.py

+++ b/slave/skia_slave_scripts/build_step.py

@@ -202,7 +202,12 @@ class BuildStep(multiprocessing.Process):

else args['perf_output_basedir'])

self.skp_dir = self._local_playback_dirs.PlaybackSkpDir()

- self.skp_out_dir = self._local_playback_dirs.PlaybackImageResultsDir()

+ self.playback_actual_images_dir = (

+ self._local_playback_dirs.PlaybackActualImagesDir())

+ self.playback_actual_summaries_dir = (

+ self._local_playback_dirs.PlaybackActualSummariesDir())

+ self.playback_expected_summaries_dir = (

+ self._local_playback_dirs.PlaybackExpectedSummariesDir())

# Figure out where we are going to store performance related data.

if args['perf_output_basedir'] != 'None':