slave/skia_slave_scripts/flavor_utils/ssh_build_step_utils.py - Issue 295753002: upload SKP renderings that did not match expectations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: slave/skia_slave_scripts/flavor_utils/ssh_build_step_utils.py

Issue 295753002: upload SKP renderings that did not match expectations (Closed) Base URL: https://skia.googlesource.com/buildbot.git@master

Patch Set: rebase Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: slave/skia_slave_scripts/flavor_utils/ssh_build_step_utils.py

diff --git a/slave/skia_slave_scripts/flavor_utils/ssh_build_step_utils.py b/slave/skia_slave_scripts/flavor_utils/ssh_build_step_utils.py

index 3fdf12f1ad6c06748ec924678f394b1ba0a351c4..2fcb22071b29cfc1cb034e3104c764d66cdd8020 100644

--- a/slave/skia_slave_scripts/flavor_utils/ssh_build_step_utils.py

+++ b/slave/skia_slave_scripts/flavor_utils/ssh_build_step_utils.py

@@ -173,7 +173,9 @@ class SshBuildStepUtils(DefaultBuildStepUtils):

skimage_out_dir=prefix + 'skimage_out',

skp_dir=prefix + 'skp',

skp_perf_dir=prefix + 'skp_perf',

- skp_out_dir=prefix + 'skp_out',

+ playback_actual_images_dir=prefix + 'playback_actual_images',

+ playback_actual_summaries_dir=prefix + 'playback_actual_summaries',

+ playback_expected_summaries_dir=prefix + 'playback_expected_summaries',

tmp_dir=prefix + 'tmp_dir')

def MakeClean(self):