upload SKP renderings that did not match expectations

slave/skia_slave_scripts/postrender.py

Index: slave/skia_slave_scripts/postrender.py
diff --git a/slave/skia_slave_scripts/postrender.py b/slave/skia_slave_scripts/postrender.py
index f3f22b32646271fbe0855dc30d191a5a9caf97e0..6caf7bfaee297e88f4f6739a4901919a236bbe83 100644
--- a/slave/skia_slave_scripts/postrender.py
+++ b/slave/skia_slave_scripts/postrender.py
@@ -10,16 +10,29 @@ import sys
 
 
 class PostRender(BuildStep):
-  def _Run(self):
+  def _RunAfterGenerateGMs(self):
     self._flavor_utils.CopyDirectoryContentsToHost(
         self._flavor_utils.DevicePathJoin(self._device_dirs.GMActualDir(),
                                           self._builder_name),
                                                    self._gm_actual_dir)
-    self._flavor_utils.CopyDirectoryContentsToHost(
-        self._device_dirs.SKPOutDir(), self.skp_out_dir)
+
+  def _RunAfterRunDecodingTests(self):
     self._flavor_utils.CopyDirectoryContentsToHost(
         self._device_dirs.SKImageOutDir(), self._skimage_out_dir)
 
+  def _RunAfterRenderSKPs(self):
+    self._flavor_utils.CopyDirectoryContentsToHost(
+        self._device_dirs.PlaybackActualImagesDir(),
+        self.playback_actual_images_dir)
+    self._flavor_utils.CopyDirectoryContentsToHost(
+        self._device_dirs.PlaybackActualSummariesDir(),
+        self.playback_actual_summaries_dir)
+
+  def _Run(self):

[epoger, 2014/05/19 19:35:40]

It was more of an issue in prerender.py than here, but in both cases I found it
easier to follow if we were clearer about which step we were cleaning up after,
for each operation.

[borenet, 2014/05/19 21:04:38]

It's possible that we should just have optional pre/post for each build step?

[epoger, 2014/05/19 22:07:24]

Do you mean...
1. Copying GM expectations to the device as part of the GenerateGMs step,
instead of as part of a separate PreRender step?  OR
2. Creating a PreGenerateGMs step that only prepares for GenerateGMs, and not
RenderSKPs/RunDecodingTests?

Downside of #1: if the copy fails, it looks like we failed while running gm
Downside of #2: ever more steps, slave script files

I prefer it as it is here: a limited number of slave scripts, but clarity as to
what step we are preparing for.

But I'm quite open to suggestion!  Feel free to grab me for live discussion
anytime on Tuesday.

+    self._RunAfterGenerateGMs()
+    self._RunAfterRunDecodingTests()
+    self._RunAfterRenderSKPs()
+
 
 if '__main__' == __name__:
   sys.exit(BuildStep.RunBuildStep(PostRender))