Start banner pipeline immediately after navigating, if enough engagement

chrome/browser/banners/app_banner_manager_browsertest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <vector>
 
 #include "base/command_line.h"
 #include "base/macros.h"
 #include "base/memory/ptr_util.h"
 #include "base/run_loop.h"
@@ skipping 36 matching lines @@
     if (validated_url == GURL("about:blank"))
       return;
 
     AppBannerManager::RequestAppBanner(validated_url, is_debug_mode);
   }
 
   bool will_show() { return will_show_.get() && *will_show_; }
 
   void clear_will_show() { will_show_.reset(); }
 
-  bool is_active() { return AppBannerManager::is_active(); }
+  bool is_active_or_pending() {
+    return AppBannerManager::is_active_or_pending();
+  }
 
   bool is_complete() { return AppBannerManager::is_complete(); }
 
   bool is_pending_engagement() {
     return AppBannerManager::is_pending_engagement();
   }
 
   bool need_to_log_status() { return need_to_log_status_; }
 
   void Prepare(base::Closure quit_closure) {
@@ skipping 78 matching lines @@
   }
 
   void RunBannerTest(Browser* browser,
                      AppBannerManagerTest* manager,
                      const std::string& url,
                      const std::vector<double>& engagement_scores,
                      InstallableStatusCode expected_code_for_histogram,
                      bool expected_to_show) {
     RunBannerTest(browser, manager, url, engagement_scores,
                   expected_code_for_histogram, expected_to_show,
-                  base::string16());
+                  base::string16(), ui::PAGE_TRANSITION_TYPED);
   }
 
   void RunBannerTest(Browser* browser,
                      AppBannerManagerTest* manager,
                      const std::string& url,
                      const std::vector<double>& engagement_scores,
                      InstallableStatusCode expected_code_for_histogram,
                      bool expected_to_show,
-                     const base::string16 expected_tab_title) {
+                     const base::string16 expected_tab_title,
+                     ui::PageTransition transition) {
     base::HistogramTester histograms;
     GURL test_url = embedded_test_server()->GetURL(url);
 
     manager->clear_will_show();
 
     // Loop through the vector of engagement scores. We only expect the banner
     // pipeline to trigger on the last one; otherwise, nothing is expected to
     // happen.
     int iterations = 0;
     SiteEngagementService* service =
         SiteEngagementService::Get(browser->profile());
     for (double engagement : engagement_scores) {
       if (iterations > 0) {
         ui_test_utils::NavigateToURL(browser, test_url);
 
         EXPECT_FALSE(manager->will_show());
-        EXPECT_FALSE(manager->is_active());
+        EXPECT_FALSE(manager->is_active_or_pending());
 
         histograms.ExpectTotalCount(banners::kMinutesHistogram, 0);
         histograms.ExpectTotalCount(banners::kInstallableStatusCodeHistogram,
                                     0);
       }
       service->ResetBaseScoreForURL(test_url, engagement);
       ++iterations;
     }
 
     // On the final loop, we expect the banner pipeline to trigger - the
     // navigation should generate the final engagement to show the banner. Spin
     // the run loop and wait for the manager to finish.
     base::RunLoop run_loop;
     manager->clear_will_show();
     manager->Prepare(run_loop.QuitClosure());
-    ui_test_utils::NavigateToURL(browser, test_url);
+    chrome::NavigateParams nav_params(browser, test_url, transition);
+    ui_test_utils::NavigateToURL(&nav_params);
     run_loop.Run();
 
     EXPECT_EQ(expected_to_show, manager->will_show());
-    EXPECT_FALSE(manager->is_active());
+    EXPECT_FALSE(manager->is_active_or_pending());
 
     // Check the tab title; this allows the test page to send data back out to
     // be inspected by the test case.
     if (!expected_tab_title.empty()) {
       base::string16 title;
       EXPECT_TRUE(ui_test_utils::GetCurrentTabTitle(browser, &title));
       EXPECT_EQ(expected_tab_title, title);
     }
 
     // If in incognito, ensure that nothing is recorded.
@@ skipping 18 matching lines @@
   RunBannerTest(browser(), manager.get(), "/banners/manifest_test_page.html",
                 engagement_scores, SHOWING_WEB_APP_BANNER, true);
 }
 
 IN_PROC_BROWSER_TEST_F(AppBannerManagerBrowserTest,
                        WebAppBannerCreatedImmediately) {
   std::unique_ptr<AppBannerManagerTest> manager(
       CreateAppBannerManager(browser()));
   std::vector<double> engagement_scores{10};
   RunBannerTest(browser(), manager.get(), "/banners/manifest_test_page.html",
-                engagement_scores, SHOWING_WEB_APP_BANNER, true);
+                engagement_scores, SHOWING_WEB_APP_BANNER, true,
+                base::string16(), ui::PAGE_TRANSITION_LINK);
 }
 
 IN_PROC_BROWSER_TEST_F(AppBannerManagerBrowserTest,
                        WebAppBannerCreatedAfterSeveralVisits) {
   std::unique_ptr<AppBannerManagerTest> manager(
       CreateAppBannerManager(browser()));
   std::vector<double> engagement_scores{0, 1, 2, 3, 4, 5, 10};
   RunBannerTest(browser(), manager.get(), "/banners/manifest_test_page.html",
                 engagement_scores, SHOWING_WEB_APP_BANNER, true);
 }
@@ skipping 69 matching lines @@
   std::unique_ptr<AppBannerManagerTest> manager(
       CreateAppBannerManager(browser()));
   std::vector<double> engagement_scores{0, 5, 10};
 
   // Expect that the page sets the tab title to indicate that it got the event
   // twice: once for addEventListener('beforeinstallprompt'), and once for the
   // onbeforeinstallprompt attribute.
   RunBannerTest(browser(), manager.get(),
                 "/banners/beforeinstallprompt_test_page.html",
                 engagement_scores, SHOWING_WEB_APP_BANNER, true,
-                base::ASCIIToUTF16("Got beforeinstallprompt: listener, attr"));
+                base::ASCIIToUTF16("Got beforeinstallprompt: listener, attr"),
+                ui::PAGE_TRANSITION_TYPED);
 }
 
 IN_PROC_BROWSER_TEST_F(AppBannerManagerBrowserTest, CancelBannerDirect) {
   std::unique_ptr<AppBannerManagerTest> manager(
       CreateAppBannerManager(browser()));
   std::vector<double> engagement_scores{10};
   RunBannerTest(browser(), manager.get(), "/banners/cancel_test_page.html",
                 engagement_scores, RENDERER_CANCELLED, false);
 }
 
@@ skipping 111 matching lines @@
   // state, without showing a banner.
   {
     base::RunLoop run_loop;
     manager->clear_will_show();
     manager->Prepare(run_loop.QuitClosure());
     ui_test_utils::NavigateToURL(browser(), test_url);
     run_loop.Run();
   }
 
   EXPECT_FALSE(manager->will_show());
-  EXPECT_FALSE(manager->is_active());
   EXPECT_TRUE(manager->is_pending_engagement());
   EXPECT_TRUE(manager->need_to_log_status());
 
   // Trigger an engagement increase that signals observers and expect the banner
   // to be shown.
   {
     base::RunLoop run_loop;
     manager->clear_will_show();
     manager->Prepare(run_loop.QuitClosure());
     service->HandleNavigation(
         browser()->tab_strip_model()->GetActiveWebContents(),
         ui::PageTransition::PAGE_TRANSITION_TYPED);
     run_loop.Run();
   }
 
   EXPECT_TRUE(manager->will_show());
-  EXPECT_FALSE(manager->is_active());
+  EXPECT_FALSE(manager->is_active_or_pending());
   EXPECT_FALSE(manager->need_to_log_status());
   EXPECT_TRUE(manager->is_complete());
 
   histograms.ExpectTotalCount(banners::kMinutesHistogram, 1);
   histograms.ExpectUniqueSample(banners::kInstallableStatusCodeHistogram,
                                 SHOWING_WEB_APP_BANNER, 1);
 }
 
 IN_PROC_BROWSER_TEST_F(AppBannerManagerBrowserTest, CheckOnLoadThenNavigate) {
   base::test::ScopedFeatureList feature_list;
@@ skipping 10 matching lines @@
   // state, without showing a banner.
   {
     base::RunLoop run_loop;
     manager->clear_will_show();
     manager->Prepare(run_loop.QuitClosure());
     ui_test_utils::NavigateToURL(browser(), test_url);
     run_loop.Run();
   }
 
   EXPECT_FALSE(manager->will_show());
-  EXPECT_FALSE(manager->is_active());
   EXPECT_TRUE(manager->is_pending_engagement());
   EXPECT_TRUE(manager->need_to_log_status());
 
   // Navigate and expect Stop() to be called.
   {
     base::RunLoop run_loop;
     manager->clear_will_show();
     manager->Prepare(run_loop.QuitClosure());
     ui_test_utils::NavigateToURL(browser(), GURL("about:blank"));
     run_loop.Run();
   }
 
   EXPECT_FALSE(manager->will_show());
-  EXPECT_FALSE(manager->is_active());
+  EXPECT_FALSE(manager->is_active_or_pending());
   EXPECT_FALSE(manager->need_to_log_status());
 
   histograms.ExpectTotalCount(banners::kMinutesHistogram, 0);
   histograms.ExpectUniqueSample(banners::kInstallableStatusCodeHistogram,
                                 INSUFFICIENT_ENGAGEMENT, 1);
 }
 
 }  // namespace banners