Start banner pipeline immediately after navigating, if enough engagement

chrome/browser/banners/app_banner_manager.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/banners/app_banner_manager.h"
 
 #include <algorithm>
 
 #include "base/bind.h"
 #include "base/command_line.h"
@@ skipping 413 matching lines @@
 
   load_finished_ = true;
   validated_url_ = validated_url;
 
   // If the bypass flag is on, or if we require no engagement to trigger the
   // banner, the rest of the banner pipeline should operate as if the engagement
   // threshold has been met.
   if (AppBannerSettingsHelper::HasSufficientEngagement(0))
     has_sufficient_engagement_ = true;
 
+  // If the page already has enough engagement, trigger the pipeline
+  // immediately.
+  if (AppBannerSettingsHelper::HasSufficientEngagement(
+          SiteEngagementService::Get(

[dominickn, 2017/06/23 04:55:35]

This is called quite a lot. Instead, just have a site_engagement_service_ member
(we already fetch it in the constructor for this object to set up the observer
anyway).

[dominickn, 2017/06/23 04:57:44]

That might also let you combine this if statement with the one above.

[benwells, 2017/06/23 05:12:04]

Done.

[benwells, 2017/06/23 05:12:04]

Done.

+              Profile::FromBrowserContext(web_contents()->GetBrowserContext()))
+              ->GetScore(validated_url))) {
+    has_sufficient_engagement_ = true;
+  }
+
   // Start the pipeline immediately if we pass (or bypass) the engagement check,
   // or if the feature to run the installability check on page load is enabled.
   if (has_sufficient_engagement_ ||
       base::FeatureList::IsEnabled(
           features::kCheckInstallabilityForBannerOnLoad)) {
     RequestAppBanner(validated_url, false /* is_debug_mode */);
   }
 }
 
 void AppBannerManager::MediaStartedPlaying(const MediaPlayerInfo& media_info,
@@ skipping 143 matching lines @@
   if (is_pending_event()) {
     // Simulate a non-canceled OnBannerPromptReply to show the delayed banner.
     OnBannerPromptReply(blink::mojom::AppBannerPromptReply::NONE, referrer_);
   } else {
     // Log that the prompt request was made for when we get the prompt reply.
     page_requested_prompt_ = true;
   }
 }
 
 }  // namespace banners