Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 2957503003: Don't peek when parsing mixin applications. (Closed)

Created:
3 years, 6 months ago by ahe
Modified:
3 years, 5 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -12 lines) Patch
M pkg/front_end/lib/src/fasta/parser/parser.dart View 3 chunks +8 lines, -7 lines 2 comments Download
M pkg/front_end/lib/src/fasta/parser/parser.md View 1 chunk +0 lines, -3 lines 0 comments Download
M pkg/front_end/lib/src/incremental/unlinked_unit.dart View 1 chunk +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 6 (2 generated)
ahe
3 years, 6 months ago (2017-06-23 14:55:17 UTC) #2
danrubel
LGTM https://codereview.chromium.org/2957503003/diff/1/pkg/front_end/lib/src/fasta/parser/parser.dart File pkg/front_end/lib/src/fasta/parser/parser.dart (right): https://codereview.chromium.org/2957503003/diff/1/pkg/front_end/lib/src/fasta/parser/parser.dart#newcode1018 pkg/front_end/lib/src/fasta/parser/parser.dart:1018: Token parseClass(Token token, Token begin, Token classKeyword, Token ...
3 years, 6 months ago (2017-06-24 22:18:51 UTC) #3
ahe
Thank you, Dan! https://codereview.chromium.org/2957503003/diff/1/pkg/front_end/lib/src/fasta/parser/parser.dart File pkg/front_end/lib/src/fasta/parser/parser.dart (right): https://codereview.chromium.org/2957503003/diff/1/pkg/front_end/lib/src/fasta/parser/parser.dart#newcode1018 pkg/front_end/lib/src/fasta/parser/parser.dart:1018: Token parseClass(Token token, Token begin, Token ...
3 years, 5 months ago (2017-06-26 11:18:16 UTC) #4
ahe
3 years, 5 months ago (2017-06-26 12:13:44 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
28084d1f8503404e9fdda3efa5b27bf441aa64d3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698