build_overrides/build.gni - Issue 2957483002: Revert of mac: Roll hermetic toolchain to Xcode 8.3.2.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build_overrides/build.gni

Issue 2957483002: Revert of mac: Roll hermetic toolchain to Xcode 8.3.2. (Closed)

Patch Set: Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build_overrides/build.gni

diff --git a/build_overrides/build.gni b/build_overrides/build.gni

index 066298f1f76b3ab6b1250488de76930ddee0e31d..7b632bd2e648b9ca86096741a375487d0365a020 100644

--- a/build_overrides/build.gni

+++ b/build_overrides/build.gni

@@ -58,8 +58,5 @@

_result = exec_script("//build/mac/should_use_hermetic_xcode.py",

[ target_os ],

"value")

- assert(_result != 2,

- "Do not allow building targets with the default" +

- "hermetic toolchain if the minimum OS version is not met.")

use_system_xcode = _result == 0

}

« no previous file with comments | « build/mac_toolchain.py ('k') | no next file » | no next file with comments »