Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Side by Side Diff: build_overrides/build.gni

Issue 2957483002: Revert of mac: Roll hermetic toolchain to Xcode 8.3.2. (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « build/mac_toolchain.py ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2016 The Chromium Authors. All rights reserved. 1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # Several dependencies of Chrome require a different min sdk when built 5 # Several dependencies of Chrome require a different min sdk when built
6 # as stand-alone projects. If this is ever not the case, these variables 6 # as stand-alone projects. If this is ever not the case, these variables
7 # can be removed. 7 # can be removed.
8 # See https://bugs.chromium.org/p/webrtc/issues/detail?id=5453. 8 # See https://bugs.chromium.org/p/webrtc/issues/detail?id=5453.
9 mac_sdk_min_build_override = "10.10" 9 mac_sdk_min_build_override = "10.10"
10 10
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
51 # instead use a hermetic install of Xcode. [The hermetic install can be 51 # instead use a hermetic install of Xcode. [The hermetic install can be
52 # obtained with gclient sync after setting the environment variable 52 # obtained with gclient sync after setting the environment variable
53 # FORCE_MAC_TOOLCHAIN]. 53 # FORCE_MAC_TOOLCHAIN].
54 use_system_xcode = "" 54 use_system_xcode = ""
55 } 55 }
56 56
57 if (use_system_xcode == "") { 57 if (use_system_xcode == "") {
58 _result = exec_script("//build/mac/should_use_hermetic_xcode.py", 58 _result = exec_script("//build/mac/should_use_hermetic_xcode.py",
59 [ target_os ], 59 [ target_os ],
60 "value") 60 "value")
61 assert(_result != 2,
62 "Do not allow building targets with the default" +
63 "hermetic toolchain if the minimum OS version is not met.")
64 use_system_xcode = _result == 0 61 use_system_xcode = _result == 0
65 } 62 }
OLDNEW
« no previous file with comments | « build/mac_toolchain.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698