src/hydrogen.cc - Issue 295743002: Refactor transitioning stores.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/hydrogen.cc

Issue 295743002: Refactor transitioning stores. (Closed) Base URL: git@github.com:v8/v8.git@master

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/hydrogen.cc

diff --git a/src/hydrogen.cc b/src/hydrogen.cc

index 697111db9c8fa12e3552e45e9266887489145fc6..964db8bdcc0af450eafe73d541871abb1e4e9c0e 100644

--- a/src/hydrogen.cc

+++ b/src/hydrogen.cc

@@ -5529,7 +5529,14 @@ HInstruction* HOptimizedGraphBuilder::BuildStoreNamedField(

if (transition_to_field) {

Handle<Map> transition(info->transition());

ASSERT(!transition->is_deprecated());

- instr->SetTransition(Add<HConstant>(transition));

+ if (transition->CanBeDeprecated()) {

+ Map::AddDependentCompilationInfo(

+ transition, DependentCode::kTransitionGroup, top_info());

+ }

+ Add<HStoreNamedField>(checked_object->ActualValue(),

+ HObjectAccess::ForMap(),

+ Add<HConstant>(transition),

+ STORE_TO_INITIALIZED_ENTRY);

}

return instr;

}

« no previous file with comments | « src/arm64/lithium-codegen-arm64.cc ('k') | src/hydrogen-check-elimination.cc » ('j') | no next file with comments »