Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1412)

Issue 295743002: Refactor transitioning stores. (Closed)

Created:
6 years, 7 months ago by Benedikt Meurer
Modified:
6 years, 7 months ago
CC:
v8-dev
Base URL:
git@github.com:v8/v8.git@master
Visibility:
Public.

Description

Refactor transitioning stores. There's actually no need to have the transition as part of the HStoreNamedField instruction. In fact, it is cleaner and faster to generate a separate HStoreNamedField for the transition map. This will also help to eliminate map stores with store elimination, as well as reduce register pressure for transitioning stores on ia32. R=hpayer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21383

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -210 lines) Patch
M src/arm/lithium-arm.h View 1 chunk +2 lines, -4 lines 0 comments Download
M src/arm/lithium-arm.cc View 3 chunks +2 lines, -9 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 chunk +0 lines, -20 lines 0 comments Download
M src/arm64/lithium-arm64.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M src/arm64/lithium-codegen-arm64.cc View 2 chunks +0 lines, -22 lines 0 comments Download
M src/hydrogen.cc View 1 chunk +8 lines, -1 line 0 comments Download
M src/hydrogen-check-elimination.cc View 2 chunks +2 lines, -10 lines 0 comments Download
M src/hydrogen-escape-analysis.cc View 1 chunk +1 line, -5 lines 0 comments Download
M src/hydrogen-instructions.h View 5 chunks +1 line, -28 lines 0 comments Download
M src/hydrogen-instructions.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M src/hydrogen-load-elimination.cc View 1 chunk +1 line, -6 lines 0 comments Download
M src/hydrogen-store-elimination.cc View 2 chunks +7 lines, -6 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 chunk +0 lines, -22 lines 0 comments Download
M src/ia32/lithium-ia32.h View 1 chunk +2 lines, -5 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 3 chunks +4 lines, -12 lines 0 comments Download
M src/lithium.h View 2 chunks +0 lines, -8 lines 0 comments Download
M src/lithium.cc View 2 chunks +0 lines, -9 lines 0 comments Download
M src/lithium-codegen.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/lithium-codegen.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 chunk +0 lines, -21 lines 0 comments Download
M src/x64/lithium-x64.cc View 3 chunks +3 lines, -8 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Benedikt Meurer
PTAL
6 years, 7 months ago (2014-05-20 09:30:17 UTC) #1
Hannes Payer (out of office)
lgtm
6 years, 7 months ago (2014-05-20 10:50:50 UTC) #2
Benedikt Meurer
6 years, 7 months ago (2014-05-20 11:06:38 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r21383 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698