Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Unified Diff: ios/chrome/browser/ui/dialogs/dialog_presenter.h

Issue 2957423002: Check page URL origin to determine JavaScript alert titles. (Closed)
Patch Set: Add string comparison unit test Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/dialogs/dialog_presenter.h
diff --git a/ios/chrome/browser/ui/dialogs/dialog_presenter.h b/ios/chrome/browser/ui/dialogs/dialog_presenter.h
index 33d38b8c4bfc9ccda6d6928e8d41ff9cc31d20be..50860d517377f189e09927f6c4c42594678bdc57 100644
--- a/ios/chrome/browser/ui/dialogs/dialog_presenter.h
+++ b/ios/chrome/browser/ui/dialogs/dialog_presenter.h
@@ -77,8 +77,11 @@ class WebState;
// view controller.
- (void)tryToPresent;
-// Create an title for the alert base on the URL.
-+ (NSString*)localizedTitleForJavaScriptAlertFromPage:(const GURL&)pageURL;
+// Creates a title for the alert base on the URL (|pageURL|), and its
+// relationship to the |mainFrameURL| (typically these are identical except for
+// when posting alerts from an embedded iframe).
++ (NSString*)localizedTitleForJavaScriptAlertFromPage:(const GURL&)pageURL
+ mainFrameURL:(const GURL&)mainFrameURL;
@end

Powered by Google App Engine
This is Rietveld 408576698