Check page URL origin to determine JavaScript alert titles.

ios/chrome/browser/ui/dialogs/dialog_presenter.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef IOS_CHROME_BROWSER_UI_DIALOGS_DIALOG_PRESENTER_H_
 #define IOS_CHROME_BROWSER_UI_DIALOGS_DIALOG_PRESENTER_H_
 
 #import <UIKit/UIKit.h>
 
 #import "base/ios/block_types.h"
@@ skipping 59 matching lines @@
 - (void)cancelDialogForWebState:(web::WebState*)webState;
 
 // Dismisses the currently presented dialog and cancels all queued dialogs.
 - (void)cancelAllDialogs;
 
 // Tries to present an alert if needed and possible. Called by the view
 // controller which will present the alert to notify that it has dismissed a
 // view controller.
 - (void)tryToPresent;
 
-// Create an title for the alert base on the URL.
+// Create an title for the alert base on the URL (|pageURL|). Assumes that
+// pageURL is the mainFrameURL. (See
+// localizedTItleForJavaScriptAlertFromPage:mainFrameURL).
 + (NSString*)localizedTitleForJavaScriptAlertFromPage:(const GURL&)pageURL;

[Eugene But (OOO till 7-30), 2017/06/29 01:00:01]

Do we even need this method? It is only used in EG tests, which actually goes
against testing best practices and defines back doors only for tests:

go/unit-test-practices?cl=head#public-apis

[PL, 2017/06/29 20:02:21]

Sure thing! I did think about this, and whether it would be worse to change
tests in three places or keep the old API pointing to the new API.

 
+// Create an title for the alert base on the URL (|pageURL|), and its

[Eugene But (OOO till 7-30), 2017/06/29 01:00:01]

s/Create/Creates

[PL, 2017/06/29 20:02:21]

Arg, done!

+// relationship to the |mainFrameURL| (typically these are identical except for
+// when posting alerts from an embedded iframe).
++ (NSString*)localizedTitleForJavaScriptAlertFromPage:(const GURL&)pageURL

[Eugene But (OOO till 7-30), 2017/06/29 01:00:01]

Do we even need this method in the public interface?

[PL, 2017/06/29 20:02:21]

It's only going to be used by the EGTest, but I think this has to stay so those
tests can run (or have this in an internal header rather than the private one?).

This does seem to break the idea of exposing API to tests only, but this was the
case before this CL.

[Eugene But (OOO till 7-30), 2017/06/29 20:35:10]

Can we just hardcode the title in those tests? A agree that encapsulation
violation was not introduced by this CL, but it's something that should be
relatively easy to fix. If it's hard to fix, then let's leave it as it is.

+                                         mainFrameURL:(const GURL&)mainFrameURL;
+
 @end
 
 @interface DialogPresenter (ExposedForTesting)
 // The dialog currently being shown.
 @property(nonatomic, readonly) AlertCoordinator* presentedDialogCoordinator;
 
 // Called when |coordinator| is stopped.
 - (void)dialogCoordinatorWasStopped:(AlertCoordinator*)coordinator;
 
 @end
 
 // Delegate protocol for DialogPresenter.
 @protocol DialogPresenterDelegate<NSObject>
 
 // Called by |presenter| before showing the queued modal dialog associated with
 // |context|.
 - (void)dialogPresenter:(DialogPresenter*)presenter
     willShowDialogForWebState:(web::WebState*)webState;
 
 // Whether the delegate is presenting another View Controller.
 @property(nonatomic, assign) BOOL presenting;
 
 @end
 
 #endif  // IOS_CHROME_BROWSER_UI_DIALOGS_DIALOG_PRESENTER_H_