Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Unified Diff: extensions/common/extension_messages_unittest.cc

Issue 2957233002: Fix parsing of effective TLD wildcarding across IPC. (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/common/extension_messages_unittest.cc
diff --git a/extensions/common/extension_messages_unittest.cc b/extensions/common/extension_messages_unittest.cc
index ea5dd033571939fa8f0aa0321f3af0e6ad3093cf..89259788074c2a02c839222e5f6510c24b90d3a4 100644
--- a/extensions/common/extension_messages_unittest.cc
+++ b/extensions/common/extension_messages_unittest.cc
@@ -34,6 +34,16 @@ void CompareExtension(const Extension& extension1,
*(second_tab_permissions.at(tab_permissions.first)))
<< tab_permissions.first;
}
+ EXPECT_EQ(extension1.permissions_data()->policy_blocked_hosts(),
+ extension2.permissions_data()->policy_blocked_hosts());
+ EXPECT_EQ(extension1.permissions_data()->policy_allowed_hosts(),
+ extension2.permissions_data()->policy_allowed_hosts());
+}
+
+static void AddPattern(URLPatternSet* extent, const std::string& pattern) {
lazyboy 2017/06/30 20:43:22 nit: since this is already in anonymous namespace,
nrpeter 2017/06/30 21:22:15 Done.
+ URLPattern parsed(URLPattern::SCHEME_ALL);
+ parsed.Parse(pattern, URLPattern::ALLOW_WILDCARD_FOR_EFFECTIVE_TLD);
+ extent->AddPattern(parsed);
}
} // namespace
@@ -62,6 +72,12 @@ TEST(ExtensionMessageTypesTest, TestLoadedParams) {
extension->permissions_data()->UpdateTabSpecificPermissions(
1, PermissionSet(tab_permissions, ManifestPermissionSet(),
URLPatternSet(), URLPatternSet()));
+ URLPatternSet runtime_blocked_hosts;
+ AddPattern(&runtime_blocked_hosts, "*://*.example.*/*");
+ URLPatternSet runtime_allowed_hosts;
+ AddPattern(&runtime_allowed_hosts, "*://good.example.com/*");
+ extension->permissions_data()->SetPolicyHostRestrictions(
+ runtime_blocked_hosts, runtime_allowed_hosts);
ExtensionMsg_Loaded_Params params_in(extension.get(), true);
EXPECT_EQ(extension->id(), params_in.id);
« extensions/common/extension_messages.cc ('K') | « extensions/common/extension_messages.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698