Fix parsing of effective TLD wildcarding across IPC.

extensions/common/extension_messages.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/common/extension_messages.h"
 
 #include <stddef.h>
 
 #include <memory>
 
@@ skipping 121 matching lines @@
   std::string spec;
   if (!ReadParam(m, iter, &valid_schemes) ||
       !ReadParam(m, iter, &spec))
     return false;
 
   // TODO(jstritar): We don't want the URLPattern to fail parsing when the
   // scheme is invalid. Instead, the pattern should parse but it should not
   // match the invalid patterns. We get around this by setting the valid
   // schemes after parsing the pattern. Update these method calls once we can
   // ignore scheme validation with URLPattern parse options. crbug.com/90544
+  // Allow effective TLD wildcarding since this check is only needed on initial

[lazyboy, 2017/06/30 20:43:22]

nit: move this comment to next line as this is talking about Parse method call
below. (And the previous comment is about SetValidSchemes)

[nrpeter, 2017/06/30 21:22:15]

Done.

+  // creation of URLPattern and not as part of serialization.

[lazyboy, 2017/06/30 20:43:22]

nit: this is deserialization, rather than serialization?

[nrpeter, 2017/06/30 21:22:15]

Done.

   p->SetValidSchemes(URLPattern::SCHEME_ALL);
-  URLPattern::ParseResult result = p->Parse(spec);
+  URLPattern::ParseResult result =
+      p->Parse(spec, URLPattern::ALLOW_WILDCARD_FOR_EFFECTIVE_TLD);
   p->SetValidSchemes(valid_schemes);
   return URLPattern::PARSE_SUCCESS == result;
 }
 
 void ParamTraits<URLPattern>::Log(const param_type& p, std::string* l) {
   LogParam(p.GetAsString(), l);
 }
 
 void ParamTraits<URLPatternSet>::GetSize(base::PickleSizer* s,
                                          const param_type& p) {
@@ skipping 236 matching lines @@
          ReadParam(m, iter, &p->policy_allowed_hosts) &&
          ReadParam(m, iter, &p->uses_default_policy_blocked_allowed_hosts);
 }
 
 void ParamTraits<ExtensionMsg_Loaded_Params>::Log(const param_type& p,
                                                   std::string* l) {
   l->append(p.id);
 }
 
 }  // namespace IPC