Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Unified Diff: ui/base/ime/input_method_chromeos.h

Issue 2957173004: Make DispatchKeyEventPostIME() asynchronous.
Patch Set: cleanup. Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/base/ime/input_method_chromeos.h
diff --git a/ui/base/ime/input_method_chromeos.h b/ui/base/ime/input_method_chromeos.h
index 3dc5a3bbb50c934b1f4c8e7c91b670fd45ec33d9..01bd2d9354e642a754c827603c88994392aac338 100644
--- a/ui/base/ime/input_method_chromeos.h
+++ b/ui/base/ime/input_method_chromeos.h
@@ -49,13 +49,19 @@ class UI_BASE_IME_EXPORT InputMethodChromeOS : public InputMethodBase {
CompositionText* out_composition) const;
// Process a key returned from the input method.
- virtual ui::EventDispatchDetails ProcessKeyEventPostIME(ui::KeyEvent* event,
- bool handled)
- WARN_UNUSED_RESULT;
+ virtual ui::EventDispatchDetails ProcessKeyEventPostIME(
+ ui::KeyEvent* event,
+ std::unique_ptr<AckCallback> ack_callback,
+ bool skip_process_filtered,
+ bool handled) WARN_UNUSED_RESULT;
// Resets context and abandon all pending results and key events.
void ResetContext();
+ ui::EventDispatchDetails DispatchKeyEventPostIME(
+ ui::KeyEvent* event,
+ std::unique_ptr<AckCallback> ack_callback) const WARN_UNUSED_RESULT;
+
private:
class PendingKeyEvent;
@@ -76,12 +82,26 @@ class UI_BASE_IME_EXPORT InputMethodChromeOS : public InputMethodBase {
// A VKEY_PROCESSKEY may be dispatched to the EventTargets.
// It returns the result of whether the event has been stopped propagation
// when dispatching post IME.
- ui::EventDispatchDetails ProcessFilteredKeyPressEvent(ui::KeyEvent* event)
- WARN_UNUSED_RESULT;
+ ui::EventDispatchDetails ProcessFilteredKeyPressEvent(
+ ui::KeyEvent* event,
+ std::unique_ptr<AckCallback> ack_callback) WARN_UNUSED_RESULT;
+
+ void PostProcessFilteredKeyPressEvent(
+ ui::KeyEvent* event,
+ TextInputClient* prev_client,
+ std::unique_ptr<AckCallback> ack_callback,
+ bool stopped_propagation);
// Processes a key event that was not filtered by the input method.
- ui::EventDispatchDetails ProcessUnfilteredKeyPressEvent(ui::KeyEvent* event)
- WARN_UNUSED_RESULT;
+ ui::EventDispatchDetails ProcessUnfilteredKeyPressEvent(
+ ui::KeyEvent* event,
+ std::unique_ptr<AckCallback> ack_callback) WARN_UNUSED_RESULT;
+
+ void PostProcessUnfilteredKeyPressEvent(
+ ui::KeyEvent* event,
+ TextInputClient* prev_client,
+ std::unique_ptr<AckCallback> ack_callback,
+ bool stopped_propagation);
// Sends input method result caused by the given key event to the focused text
// input client.

Powered by Google App Engine
This is Rietveld 408576698