Update toast behavior and apperance according to UX requirement

chrome/browser/android/vr_shell/ui_scene_manager.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/android/vr_shell/ui_scene_manager.h"
 
 #include "base/callback.h"
 #include "base/memory/ptr_util.h"
 #include "chrome/browser/android/vr_shell/textures/close_button_texture.h"
 #include "chrome/browser/android/vr_shell/textures/ui_texture.h"
 #include "chrome/browser/android/vr_shell/ui_browser_interface.h"
 #include "chrome/browser/android/vr_shell/ui_elements/button.h"
+#include "chrome/browser/android/vr_shell/ui_elements/exclusive_screen_toast.h"
 #include "chrome/browser/android/vr_shell/ui_elements/exit_prompt.h"
 #include "chrome/browser/android/vr_shell/ui_elements/exit_prompt_backplane.h"
 #include "chrome/browser/android/vr_shell/ui_elements/loading_indicator.h"
 #include "chrome/browser/android/vr_shell/ui_elements/screen_dimmer.h"
 #include "chrome/browser/android/vr_shell/ui_elements/system_indicator.h"
 #include "chrome/browser/android/vr_shell/ui_elements/transient_url_bar.h"
 #include "chrome/browser/android/vr_shell/ui_elements/ui_element.h"
 #include "chrome/browser/android/vr_shell/ui_elements/ui_element_debug_id.h"
 #include "chrome/browser/android/vr_shell/ui_elements/url_bar.h"
 #include "chrome/browser/android/vr_shell/ui_scene.h"
@@ skipping 50 matching lines @@
 
 static constexpr float kTransientUrlBarDistance = 1.4;
 static constexpr float kTransientUrlBarWidth =
     kUrlBarWidthDMM * kTransientUrlBarDistance;
 static constexpr float kTransientUrlBarHeight =
     kUrlBarHeightDMM * kTransientUrlBarDistance;
 static constexpr float kTransientUrlBarVerticalOffset =
     -0.2 * kTransientUrlBarDistance;
 static constexpr int kTransientUrlBarTimeoutSeconds = 6;
 
-static constexpr float kToastDistance = 1.4;
-static constexpr float kToastWidth = 0.512 * kToastDistance;
-static constexpr float kToastHeight = 0.16 * kToastDistance;
+static constexpr float kWebVrToastDistance = 1.0;
+static constexpr float kFullscreenToastDistance = kFullscreenDistance;
+static constexpr float kToastWidthDMM = 0.512;
+static constexpr float kToastHeightDMM = 0.064;
+static constexpr float kToastOffsetDMM = 0.004;
+// When changing the value here, make sure it doesn't collide with
+// kWarningAngleRadians.
+static constexpr float kWebVrAngleRadians = 9.88 * M_PI / 180.0;
 static constexpr int kToastTimeoutSeconds = kTransientUrlBarTimeoutSeconds;
 
 static constexpr float kSplashScreenDistance = 1;
 static constexpr float kSplashScreenIconDMM = 0.12;
 static constexpr float kSplashScreenIconHeight =
     kSplashScreenIconDMM * kSplashScreenDistance;
 static constexpr float kSplashScreenIconWidth =
     kSplashScreenIconDMM * kSplashScreenDistance;
 static constexpr float kSplashScreenIconVerticalOffset =
     0.2 * kSplashScreenDistance;
@@ skipping 327 matching lines @@
   content_elements_.push_back(element.get());
   scene_->AddUiElement(std::move(element));
 }
 
 void UiSceneManager::CreateToasts() {
   std::unique_ptr<UiElement> element =
       base::MakeUnique<ExclusiveScreenToast>(512);
   element->set_debug_id(kExclusiveScreenToast);
   element->set_id(AllocateId());
   element->set_fill(vr_shell::Fill::NONE);
-  element->set_size({kToastWidth, kToastHeight, 1});
-  element->set_translation({0, 0, -kToastDistance});
+  element->set_size({kToastWidthDMM, kToastHeightDMM, 1});

[amp, 2017/06/28 16:47:21]

Don't the DMM need to be multiplied by the distance before being used?

Or is that what set_scale does below?  (in which case why don't we do that for
other elements?)

[bshe, 2017/06/28 20:01:58]

It is what set_scale does. It is unclear to me if we have a preference of one
over the other in each individual case. 
In my case, use set_scale makes much more sense. The real element size was
dynamically calculated based on the string length. And only the height of toast
stays the same. After calculation, I shouldn't change the size at all.

   element->set_visible(false);
   element->set_hit_testable(false);
-  element->set_lock_to_fov(true);
   exclusive_screen_toast_ = element.get();
   scene_->AddUiElement(std::move(element));
 }
 
 base::WeakPtr<UiSceneManager> UiSceneManager::GetWeakPtr() {
   return weak_ptr_factory_.GetWeakPtr();
 }
 
 void UiSceneManager::SetWebVrMode(bool web_vr, bool show_toast) {
   if (web_vr_mode_ == web_vr && web_vr_show_toast_ == show_toast) {
@@ skipping 65 matching lines @@
         {0, kContentVerticalOffset, -kContentDistance});
     main_content_->set_size({kContentWidth, kContentHeight, 1});
 
     close_button_->set_translation(
         gfx::Vector3dF(0, kContentVerticalOffset - (kContentHeight / 2) - 0.3,
                        -kCloseButtonDistance));
     close_button_->set_size(
         gfx::Vector3dF(kCloseButtonWidth, kCloseButtonHeight, 1));
   }
 
+  if (fullscreen_ && !web_vr_mode_) {

[cjgrant, 2017/06/28 13:55:34]

Why not put this block into ConfigureExclusiveScreenToast, and call it here? 
IMO, that method's job is to do exactly what this code is doing.

[bshe, 2017/06/28 20:01:58]

I am trying to make rebase easier. Your refactor patch will get rid of
ConfigureExclusiveScreenToast, right?

[cjgrant, 2017/06/28 20:24:50]

Yes, it does, currently, but when there's this much code, it should continue to
exist.

[bshe, 2017/06/29 01:34:11]

Done.

+    // Do not set size again. The size might have been changed by the backing
+    // texture size in UpdateElementSize.
+    exclusive_screen_toast_->set_scale(
+        {kFullscreenToastDistance, kFullscreenToastDistance, 1});
+    exclusive_screen_toast_->set_translation(
+        {0,
+         kFullscreenVerticalOffset + kFullscreenHeight / 2 +
+             (kToastOffsetDMM + kToastHeightDMM) * kFullscreenToastDistance,
+         -kFullscreenToastDistance});
+    exclusive_screen_toast_->set_rotation(
+        gfx::Quaternion(gfx::Vector3dF(1, 0, 0), 0.0));
+    exclusive_screen_toast_->set_lock_to_fov(false);
+  } else if (web_vr_mode_ && web_vr_show_toast_) {
+    exclusive_screen_toast_->set_scale(
+        {kWebVrToastDistance, kWebVrToastDistance, 1});
+    exclusive_screen_toast_->set_translation(
+        gfx::Vector3dF(0, kWebVrToastDistance * sin(kWebVrAngleRadians),
+                       -kWebVrToastDistance * cos(kWebVrAngleRadians)));
+    exclusive_screen_toast_->set_rotation(
+        gfx::Quaternion(gfx::Vector3dF(1, 0, 0), kWebVrAngleRadians));
+    exclusive_screen_toast_->set_lock_to_fov(true);
+  }
+
   scene_->SetMode(mode());
   scene_->SetBackgroundDistance(main_content_->translation().z() *
                                 -kBackgroundDistanceMultiplier);
   UpdateBackgroundColor();
 
   // Configure other subsystems here as well. Ultimately, it would be nice if we
   // could configure all elements through ConfigureScene(), as the exact
   // conditions that control each element are getting complicated. More systems
   // should move in here, such that a single method call can update the entire
   // scene. The drawback is slightly more overhead for individual scene
@@ skipping 256 matching lines @@
   if (fullscreen_)
     return ColorScheme::kModeFullscreen;
   return ColorScheme::kModeNormal;
 }
 
 const ColorScheme& UiSceneManager::color_scheme() const {
   return ColorScheme::GetColorScheme(mode());
 }
 
 }  // namespace vr_shell