ios/web/navigation/session_storage_builder.mm - Issue 2957163002: [Navigation Experiment] Add WKBasedNavigationManagerImpl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/web/navigation/session_storage_builder.mm

Issue 2957163002: [Navigation Experiment] Add WKBasedNavigationManagerImpl. (Closed)

Patch Set: Patch for landing Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/web/navigation/session_storage_builder.mm

diff --git a/ios/web/navigation/session_storage_builder.mm b/ios/web/navigation/session_storage_builder.mm

index 621b5b8a3338312660b419a3d054d91b9e1131ec..a134b8ea0d8b31efe266dcae705ec53bdde42880 100644

--- a/ios/web/navigation/session_storage_builder.mm

+++ b/ios/web/navigation/session_storage_builder.mm

@@ -90,9 +90,7 @@ void SessionStorageBuilder::ExtractSessionState(

lastCommittedItemIndex:last_committed_item_index]);

[session_controller setPreviousItemIndex:storage.previousItemIndex];

- auto navigation_manager = base::MakeUnique<LegacyNavigationManagerImpl>();

- navigation_manager->SetSessionController(session_controller);

- web_state->navigation_manager_.reset(navigation_manager.release());

+ web_state->navigation_manager_->SetSessionController(session_controller);

SessionCertificatePolicyCacheStorageBuilder cert_builder;

std::unique_ptr<SessionCertificatePolicyCacheImpl> cert_policy_cache =