Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1100)

Unified Diff: ios/web/navigation/navigation_manager_delegate.h

Issue 2957163002: [Navigation Experiment] Add WKBasedNavigationManagerImpl. (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/web/navigation/navigation_manager_delegate.h
diff --git a/ios/web/navigation/navigation_manager_delegate.h b/ios/web/navigation/navigation_manager_delegate.h
index 90c7675c057dbe66f4fb3fee2fe05244a4faba5d..d5f91f62768b73cddd53b81eeaa4e6a1d7865c53 100644
--- a/ios/web/navigation/navigation_manager_delegate.h
+++ b/ios/web/navigation/navigation_manager_delegate.h
@@ -5,7 +5,9 @@
#ifndef IOS_WEB_NAVIGATION_NAVIGATION_MANAGER_DELEGATE_H_
#define IOS_WEB_NAVIGATION_NAVIGATION_MANAGER_DELEGATE_H_
+#import <WebKit/WebKit.h>
#include <stddef.h>
+#include <memory>
#import "ios/web/public/navigation_manager.h"
@@ -13,6 +15,7 @@ namespace web {
struct LoadCommittedDetails;
class WebState;
+class WebViewNavigationProxy;
// Delegate for NavigationManager to hand off parts of the navigation flow.
class NavigationManagerDelegate {
@@ -42,6 +45,9 @@ class NavigationManagerDelegate {
// Returns the WebState associated with this delegate.
virtual WebState* GetWebState() = 0;
+
+ // Returns the main WKWebView used to display web content.
+ virtual WebViewNavigationProxy* GetWebViewNavigationProxy() const = 0;
Eugene But (OOO till 7-30) 2017/06/27 22:02:00 Would it make sense to have WKBasedNavigationManag
danyao 2017/06/28 22:11:04 I prefer this over SetWebViewNavigationProxy for a
Eugene But (OOO till 7-30) 2017/06/29 01:48:18 It's just somewhat strange that delegate has Get<S
};
} // namespace web

Powered by Google App Engine
This is Rietveld 408576698