Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(586)

Side by Side Diff: ios/web/navigation/navigation_manager_impl.h

Issue 2957163002: [Navigation Experiment] Add WKBasedNavigationManagerImpl. (Closed)
Patch Set: Patch for review Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef IOS_WEB_NAVIGATION_NAVIGATION_MANAGER_IMPL_H_ 5 #ifndef IOS_WEB_NAVIGATION_NAVIGATION_MANAGER_IMPL_H_
6 #define IOS_WEB_NAVIGATION_NAVIGATION_MANAGER_IMPL_H_ 6 #define IOS_WEB_NAVIGATION_NAVIGATION_MANAGER_IMPL_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 9
10 #include <memory> 10 #include <memory>
(...skipping 113 matching lines...) Expand 10 before | Expand all | Expand 10 after
124 // moved from CRWWebController to NavigationManagerImpl. 124 // moved from CRWWebController to NavigationManagerImpl.
125 virtual int GetIndexForOffset(int offset) const = 0; 125 virtual int GetIndexForOffset(int offset) const = 0;
126 126
127 // Returns the index of the previous item. Only used by SessionStorageBuilder. 127 // Returns the index of the previous item. Only used by SessionStorageBuilder.
128 virtual int GetPreviousItemIndex() const = 0; 128 virtual int GetPreviousItemIndex() const = 0;
129 129
130 protected: 130 protected:
131 // The SessionStorageBuilder functions require access to private variables of 131 // The SessionStorageBuilder functions require access to private variables of
132 // NavigationManagerImpl. 132 // NavigationManagerImpl.
133 friend SessionStorageBuilder; 133 friend SessionStorageBuilder;
134 134
Eugene But (OOO till 7-30) 2017/06/29 01:48:19 Do you want to file a bug and add a TODO to remove
danyao 2017/06/29 16:05:25 Done.
135 // Identical to GetItemAtIndex() but returns the underlying NavigationItemImpl 135 // Identical to GetItemAtIndex() but returns the underlying NavigationItemImpl
136 // instead of the public NavigationItem interface. This is used by 136 // instead of the public NavigationItem interface. This is used by
137 // SessionStorageBuilder to persist session state. 137 // SessionStorageBuilder to persist session state.
138 virtual NavigationItemImpl* GetNavigationItemImplAtIndex( 138 virtual NavigationItemImpl* GetNavigationItemImplAtIndex(
139 size_t index) const = 0; 139 size_t index) const = 0;
140
141 // Checks whether or not two URL are an in-page navigation (differing only
142 // in the fragment).
143 static bool AreURLsInPageNavigation(const GURL& existing_url,
Eugene But (OOO till 7-30) 2017/06/29 01:48:19 Could you please rename this to AreUrlsFragmentCha
danyao 2017/06/29 16:05:25 Done.
144 const GURL& new_url);
140 }; 145 };
141 146
142 } // namespace web 147 } // namespace web
143 148
144 #endif // IOS_WEB_NAVIGATION_NAVIGATION_MANAGER_IMPL_H_ 149 #endif // IOS_WEB_NAVIGATION_NAVIGATION_MANAGER_IMPL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698