Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7781)

Unified Diff: chrome/test/data/webui/settings/basic_page_browsertest.js

Issue 2957153003: MD Settings: remove unsupported routes from guest-mode. (Closed)
Patch Set: merge Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/data/webui/settings/basic_page_browsertest.js
diff --git a/chrome/test/data/webui/settings/basic_page_browsertest.js b/chrome/test/data/webui/settings/basic_page_browsertest.js
index 609c5ca1b49dbf42775decb7e994d6a6e4798d9f..458cd009ad91a2dc0aa7e3d9fc5d7c5d8f6ea6bc 100644
--- a/chrome/test/data/webui/settings/basic_page_browsertest.js
+++ b/chrome/test/data/webui/settings/basic_page_browsertest.js
@@ -96,7 +96,7 @@ TEST_F('SettingsBasicPageBrowserTest', 'DISABLED_Load', function() {
test('scroll to section', function() {
var page = self.basicPage;
// Setting the page and section will cause a scrollToSection_.
- settings.navigateTo(settings.Route.ON_STARTUP);
+ settings.navigateTo(settings.routes.ON_STARTUP);
return new Promise(function(resolve, reject) {
// This test checks for a regression that occurred with scrollToSection_
@@ -134,14 +134,15 @@ TEST_F('SettingsBasicPageBrowserTest', 'DISABLED_Load', function() {
var searchManager = new TestSearchManager();
settings.setSearchManagerForTesting(searchManager);
- settings.navigateTo(settings.Route.BASIC,
- new URLSearchParams(`search=foobar`),
- /* removeSearch */ false);
+ settings.navigateTo(
+ settings.routes.BASIC, new URLSearchParams(`search=foobar`),
+ /* removeSearch */ false);
return searchManager.whenCalled('search').then(function() {
return new Promise(function(resolve) {
- settings.navigateTo(settings.Route.ON_STARTUP,
- /* dynamicParams */ null,
- /* removeSearch */ true);
+ settings.navigateTo(
+ settings.routes.ON_STARTUP,
+ /* dynamicParams */ null,
+ /* removeSearch */ true);
assertTrue(!!page);
@@ -161,10 +162,10 @@ TEST_F('SettingsBasicPageBrowserTest', 'DISABLED_Load', function() {
// Set the viewport small to force the scrollbar to appear on ABOUT.
Polymer.dom().querySelector('settings-ui').style.height = '200px';
- settings.navigateTo(settings.Route.ON_STARTUP);
+ settings.navigateTo(settings.routes.ON_STARTUP);
assertNotEquals(0, page.scroller.scrollTop);
- settings.navigateTo(settings.Route.ABOUT);
+ settings.navigateTo(settings.routes.ABOUT);
assertEquals(0, page.scroller.scrollTop);
});
});
« no previous file with comments | « chrome/test/data/webui/settings/android_apps_page_test.js ('k') | chrome/test/data/webui/settings/cr_settings_browsertest.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698