Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5383)

Unified Diff: chrome/browser/resources/settings/site_settings_page/site_settings_page.js

Issue 2957153003: MD Settings: remove unsupported routes from guest-mode. (Closed)
Patch Set: safeguard all settings.routes.[ROUTE]. dereferencing Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/site_settings_page/site_settings_page.js
diff --git a/chrome/browser/resources/settings/site_settings_page/site_settings_page.js b/chrome/browser/resources/settings/site_settings_page/site_settings_page.js
index ce8e6fda2868519a77d2b70fad65b0f37b82ee32..9dba29a626e0501e91b14881dc4af778e179f515 100644
--- a/chrome/browser/resources/settings/site_settings_page/site_settings_page.js
+++ b/chrome/browser/resources/settings/site_settings_page/site_settings_page.js
@@ -71,7 +71,7 @@ Polymer({
// Populate the |focusConfig| map of the parent <settings-animated-pages>
// element, with additional entries that correspond to subpage trigger
// elements residing in this element's Shadow DOM.
- var R = settings.Route;
+ var R = settings.routes;
[[R.SITE_SETTINGS_COOKIES, 'cookies'],
[R.SITE_SETTINGS_LOCATION, 'location'], [R.SITE_SETTINGS_CAMERA, 'camera'],
[R.SITE_SETTINGS_MICROPHONE, 'microphone'],
@@ -173,6 +173,6 @@ Polymer({
*/
onTapNavigate_: function(event) {
var dataSet = /** @type {{route: string}} */ (event.currentTarget.dataset);
- settings.navigateTo(settings.Route[dataSet.route]);
+ settings.navigateTo(settings.routes[dataSet.route]);
},
});

Powered by Google App Engine
This is Rietveld 408576698