chrome/browser/resources/settings/internet_page/internet_detail_page.js - Issue 2957153003: MD Settings: remove unsupported routes from guest-mode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/internet_page/internet_detail_page.js

Issue 2957153003: MD Settings: remove unsupported routes from guest-mode. (Closed)

Patch Set: safeguard all settings.routes.[ROUTE]. dereferencing Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/internet_page/internet_config.js ('k') | chrome/browser/resources/settings/internet_page/internet_page.js » ('j') | chrome/browser/resources/settings/route.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/internet_page/internet_detail_page.js

diff --git a/chrome/browser/resources/settings/internet_page/internet_detail_page.js b/chrome/browser/resources/settings/internet_page/internet_detail_page.js

index a56d342016bea85b30ee299dd28f2f543735dfb4..f67cb6db2020b0cf7cd92aebf4e69c00d4d23ee0 100644

--- a/chrome/browser/resources/settings/internet_page/internet_detail_page.js

+++ b/chrome/browser/resources/settings/internet_page/internet_detail_page.js

@@ -158,7 +158,7 @@ Polymer({

* @protected

currentRouteChanged: function(route, oldRoute) {

- if (route != settings.Route.NETWORK_DETAIL) {

+ if (route != settings.routes.NETWORK_DETAIL) {

if (this.networksChangedListener_) {

this.networkingPrivate.onNetworksChanged.removeListener(

this.networksChangedListener_);

@@ -185,7 +185,7 @@ Polymer({

this.shoudlShowConfigureWhenNetworkLoaded_ =

queryParams.get('showConfigure') == 'true';

this.wasPreviousRouteNetworkDetailPage_ =

- oldRoute == settings.Route.NETWORK_DETAIL;

+ oldRoute == settings.routes.NETWORK_DETAIL;

var name = queryParams.get('name') || type;

this.networkProperties = {

GUID: this.guid,