Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Unified Diff: net/disk_cache/simple/simple_backend_impl.h

Issue 2957133002: Implement in-memory byte hints in SimpleCache (Closed)
Patch Set: Move RoundSize within the #ifdef, so win_clang build doesn't complain about it being unused, with t… Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/disk_cache/simple/simple_backend_impl.h
diff --git a/net/disk_cache/simple/simple_backend_impl.h b/net/disk_cache/simple/simple_backend_impl.h
index aa7a3785afc91af89f04bb8b75b344ee207d6690..0107d1ff287942c76507898459bfd1f3202a9ae4 100644
--- a/net/disk_cache/simple/simple_backend_impl.h
+++ b/net/disk_cache/simple/simple_backend_impl.h
@@ -120,6 +120,8 @@ class NET_EXPORT_PRIVATE SimpleBackendImpl : public Backend,
size_t DumpMemoryStats(
base::trace_event::ProcessMemoryDump* pmd,
const std::string& parent_absolute_name) const override;
+ uint8_t GetMemoryEntryData(const std::string& key) override;
pasko 2017/06/29 16:31:49 nit: maybe GetEntryInMemoryData, which would be cl
gavinp 2017/08/04 18:42:54 +1
Maks Orlovich 2017/08/23 19:29:05 Acknowledged.
Maks Orlovich 2017/08/23 19:29:05 Copy-pasted this comment to the interface CL, sinc
+ void SetMemoryEntryData(const std::string& key, uint8_t data) override;
private:
class SimpleIterator;

Powered by Google App Engine
This is Rietveld 408576698