Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Issue 295713004: options: temporarily fix text rendering bug in overlays. (Closed)

Created:
6 years, 7 months ago by Dan Beam
Modified:
6 years, 7 months ago
Reviewers:
reveman
CC:
chromium-reviews, oshima+watch_chromium.org
Visibility:
Public.

Description

options: temporarily fix text rendering bug in overlays. R=reveman@chromium.org BUG=372765 TEST=visual Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271580

Patch Set 1 : fix #

Total comments: 2

Patch Set 2 : reveman@ review #

Total comments: 2

Patch Set 3 : comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M ui/webui/resources/css/overlay.css View 1 2 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
reveman
https://codereview.chromium.org/295713004/diff/20001/ui/webui/resources/css/overlay.css File ui/webui/resources/css/overlay.css (right): https://codereview.chromium.org/295713004/diff/20001/ui/webui/resources/css/overlay.css#newcode33 ui/webui/resources/css/overlay.css:33: -webkit-perspective: 1px; hm, I think this needs to be ...
6 years, 7 months ago (2014-05-19 21:50:25 UTC) #1
Dan Beam
https://codereview.chromium.org/295713004/diff/20001/ui/webui/resources/css/overlay.css File ui/webui/resources/css/overlay.css (right): https://codereview.chromium.org/295713004/diff/20001/ui/webui/resources/css/overlay.css#newcode33 ui/webui/resources/css/overlay.css:33: -webkit-perspective: 1px; On 2014/05/19 21:50:25, reveman wrote: > hm, ...
6 years, 7 months ago (2014-05-19 21:59:22 UTC) #2
reveman
lgtm https://codereview.chromium.org/295713004/diff/40001/ui/webui/resources/css/overlay.css File ui/webui/resources/css/overlay.css (right): https://codereview.chromium.org/295713004/diff/40001/ui/webui/resources/css/overlay.css#newcode10 ui/webui/resources/css/overlay.css:10: -webkit-perspective: 1px; nit: maybe worth adding a TODO ...
6 years, 7 months ago (2014-05-19 22:25:31 UTC) #3
Dan Beam
The CQ bit was checked by dbeam@chromium.org
6 years, 7 months ago (2014-05-19 22:37:52 UTC) #4
Dan Beam
https://codereview.chromium.org/295713004/diff/40001/ui/webui/resources/css/overlay.css File ui/webui/resources/css/overlay.css (right): https://codereview.chromium.org/295713004/diff/40001/ui/webui/resources/css/overlay.css#newcode10 ui/webui/resources/css/overlay.css:10: -webkit-perspective: 1px; On 2014/05/19 22:25:32, reveman wrote: > nit: ...
6 years, 7 months ago (2014-05-19 22:37:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dbeam@chromium.org/295713004/80001
6 years, 7 months ago (2014-05-19 22:38:32 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-20 02:03:22 UTC) #7
commit-bot: I haz the power
6 years, 7 months ago (2014-05-20 06:16:03 UTC) #8
Message was sent while issue was closed.
Change committed as 271580

Powered by Google App Engine
This is Rietveld 408576698