Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1461)

Unified Diff: chrome/browser/android/banners/app_banner_manager_android.cc

Issue 2957063002: Update app banner state machine to use more states. (Closed)
Patch Set: Feedback Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/banners/app_banner_manager_android.cc
diff --git a/chrome/browser/android/banners/app_banner_manager_android.cc b/chrome/browser/android/banners/app_banner_manager_android.cc
index 967a2758bc5c69bec129069421e97fe9a77b25c7..a5c127458dd9730bd3f1ddcfaaab921e08bdd025 100644
--- a/chrome/browser/android/banners/app_banner_manager_android.cc
+++ b/chrome/browser/android/banners/app_banner_manager_android.cc
@@ -87,10 +87,10 @@ AppBannerManagerAndroid::GetJavaBannerManager() const {
return java_banner_manager_;
}
-bool AppBannerManagerAndroid::IsActiveForTesting(
+bool AppBannerManagerAndroid::IsRunningForTesting(
JNIEnv* env,
const JavaParamRef<jobject>& obj) {
- return is_active();
+ return IsRunning();
}
void AppBannerManagerAndroid::RecordMenuOpen(JNIEnv* env,
@@ -225,10 +225,8 @@ void AppBannerManagerAndroid::OnAppIconFetched(const SkBitmap& bitmap) {
if (bitmap.drawsNothing()) {
ReportStatus(web_contents(), NO_ICON_AVAILABLE);
Stop();
- }
-
- if (!is_active())
return;
+ }
primary_icon_ = bitmap;
SendBannerPromptRequest();
« no previous file with comments | « chrome/browser/android/banners/app_banner_manager_android.h ('k') | chrome/browser/banners/app_banner_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698