Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Unified Diff: ash/system/network/network_list.cc

Issue 2957043002: Add a row in the network tray to inform users to turn Bluetooth on to enable Tether. (Closed)
Patch Set: Overhaul of previous implementation Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/system/network/network_list.cc
diff --git a/ash/system/network/network_list.cc b/ash/system/network/network_list.cc
index 9ed47151bdadd73493461f693f89e7b1972e9aa5..074cb18c73763996bcf228d51b9091d5649d605c 100644
--- a/ash/system/network/network_list.cc
+++ b/ash/system/network/network_list.cc
@@ -641,9 +641,11 @@ void NetworkListView::UpdateInfoLabel(int message_id,
return;
}
if (!info_label)
- info_label = new InfoLabel(message_id);
+ info_label = TrayDetailsView::CreateInfoLabel(
Kyle Horimoto 2017/07/07 17:33:59 This will only create an info label of a given typ
tdanderson 2017/07/07 21:25:11 +1, and IMO this is the most awkward part to deal
Kyle Horimoto 2017/07/07 21:39:25 This plan sounds great to me! Leslie, let me know
lesliewatkins 2017/07/09 00:57:47 I hopefully did some variation of this, but again,
+ message_id); // new InfoLabel(message_id);
Kyle Horimoto 2017/07/07 17:33:59 Remove comment, make into a single line of code.
lesliewatkins 2017/07/09 00:57:47 Done.
else
info_label->SetMessage(message_id);
+
PlaceViewAtIndex(info_label, insertion_index);
*info_label_ptr = info_label;
}

Powered by Google App Engine
This is Rietveld 408576698