Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(597)

Unified Diff: ash/system/network/network_icon.cc

Issue 2957043002: Add a row in the network tray to inform users to turn Bluetooth on to enable Tether. (Closed)
Patch Set: added actions and slightly refactored the infolabel class Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/system/network/network_icon.cc
diff --git a/ash/system/network/network_icon.cc b/ash/system/network/network_icon.cc
index f096341b7e0726c1cb28b4aa5dd2e0b492274219..0fcb08239e5ef7871a274c8585d195a4f4521f20 100644
--- a/ash/system/network/network_icon.cc
+++ b/ash/system/network/network_icon.cc
@@ -881,10 +881,13 @@ int GetMobileUninitializedMsg() {
static int s_uninitialized_msg(0);
NetworkStateHandler* handler = NetworkHandler::Get()->network_state_handler();
- if (handler->GetTechnologyState(NetworkTypePattern::Mobile()) ==
+ if (handler->GetTechnologyState(NetworkTypePattern::Tether()) ==
NetworkStateHandler::TECHNOLOGY_UNINITIALIZED) {
Kyle Horimoto 2017/06/27 19:36:56 This condition also occurs if IsCellularAvailableB
Kyle Horimoto 2017/06/29 19:24:32 I added a quick CL to help you on this. Use https:
lesliewatkins 2017/07/07 16:19:19 Will incorporate as soon as this lands. Thanks for
- // TODO (lesliewatkins): Add a more descriptive message (e.g. "Enable
- // Bluetooth") for Tether technology type.
+ s_uninitialized_msg = IDS_ASH_STATUS_TRAY_ENABLE_BLUETOOTH;
+ s_uninitialized_state_time = base::Time::Now();
+ return s_uninitialized_msg;
+ } else if (handler->GetTechnologyState(NetworkTypePattern::Mobile()) ==
Kyle Horimoto 2017/06/27 19:36:56 Does this change fix https://bugs.chromium.org/p/c
lesliewatkins 2017/07/07 16:19:19 Done.
+ NetworkStateHandler::TECHNOLOGY_UNINITIALIZED) {
s_uninitialized_msg = IDS_ASH_STATUS_TRAY_INITIALIZING_CELLULAR;
s_uninitialized_state_time = base::Time::Now();
return s_uninitialized_msg;

Powered by Google App Engine
This is Rietveld 408576698