Add a row in the network tray to inform users to turn Bluetooth on to enable Tether.

ash/system/network/network_icon.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/system/network/network_icon.h"
 
 #include "ash/resources/vector_icons/vector_icons.h"
 #include "ash/strings/grit/ash_strings.h"
 #include "ash/system/network/network_icon_animation.h"
 #include "ash/system/network/network_icon_animation_observer.h"
@@ skipping 859 matching lines @@
 
   // Otherwise just show the network name or 'Ethernet'.
   if (network->Matches(NetworkTypePattern::Ethernet())) {
     return l10n_util::GetStringUTF16(IDS_ASH_STATUS_TRAY_ETHERNET);
   } else {
     return base::UTF8ToUTF16(network->name());
   }
 }
 
 int GetMobileUninitializedMsg() {
   static base::Time s_uninitialized_state_time;

[James Cook, 2017/07/10 18:43:03]

Aside: You didn't add it in this CL, but I'm a little surprised this doesn't
create a static-initializer warning. Google C++ style does not allow
non-plain-old-data statics/globals. Perhaps this works because the underlying
storage is int64.

https://google.github.io/styleguide/cppguide.html#Static_and_Global_Variables

Future code like this should store the data as a member variable in a class
somewhere (awkward for functions like this, I know).

[lesliewatkins, 2017/07/12 21:49:49]

Acknowledged.

   static int s_uninitialized_msg(0);
 
   NetworkStateHandler* handler = NetworkHandler::Get()->network_state_handler();
-  if (handler->GetTechnologyState(NetworkTypePattern::Mobile()) ==
+  // TODO (lesliewatkins): Only return this message when Tether is uninitialized

[James Cook, 2017/07/10 18:43:03]

nit: no space after TODO

[lesliewatkins, 2017/07/12 21:49:49]

Done.

+  // due to no Bluetooth (dependent on 2969493002).

[James Cook, 2017/07/10 18:43:03]

nit: b/12345 for internal bugs (assuming that's an internal bug number), or cite
a crbug.

[Kyle Horimoto, 2017/07/10 19:15:37]

It's actually a Chromium CL number: https://codereview.chromium.org/2969493002/

[lesliewatkins, 2017/07/12 21:49:49]

Changed!

+  if (handler->GetTechnologyState(NetworkTypePattern::Tether()) ==
       NetworkStateHandler::TECHNOLOGY_UNINITIALIZED) {
-    // TODO (lesliewatkins): Add a more descriptive message (e.g. "Enable
-    // Bluetooth") for Tether technology type.
+    s_uninitialized_msg = IDS_ASH_STATUS_TRAY_ENABLE_BLUETOOTH;
+    s_uninitialized_state_time = base::Time::Now();
+    return s_uninitialized_msg;
+  } else if (handler->GetTechnologyState(NetworkTypePattern::Mobile()) ==
+             NetworkStateHandler::TECHNOLOGY_UNINITIALIZED) {
     s_uninitialized_msg = IDS_ASH_STATUS_TRAY_INITIALIZING_CELLULAR;
     s_uninitialized_state_time = base::Time::Now();
     return s_uninitialized_msg;
   } else if (handler->GetScanningByType(NetworkTypePattern::Mobile())) {
     s_uninitialized_msg = IDS_ASH_STATUS_TRAY_MOBILE_SCANNING;
     s_uninitialized_state_time = base::Time::Now();
     return s_uninitialized_msg;
   }
   // There can be a delay between leaving the Initializing state and when
   // a Mobile device shows up, so keep showing the initializing
@@ skipping 95 matching lines @@
     network_paths.insert((*iter)->path());
   }
   PurgeIconMap(ICON_TYPE_TRAY, network_paths);
   PurgeIconMap(ICON_TYPE_DEFAULT_VIEW, network_paths);
   PurgeIconMap(ICON_TYPE_LIST, network_paths);
   PurgeIconMap(ICON_TYPE_MENU_LIST, network_paths);
 }
 
 }  // namespace network_icon
 }  // namespace ash