Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 295703002: Revert 271398 "Blink roll 174243:174291" (Closed)

Created:
6 years, 7 months ago by ericu
Modified:
6 years, 7 months ago
Reviewers:
timvolodine, eseidel
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 271398 "Blink roll 174243:174291" This was the only CL in this build: Test failures: http://build.chromium.org/p/chromium.mac/builders/Mac%2010.7%20Tests%20%28dbg%29%281%29/builds/23684 browser_tests browser_tests browser_tests 381 disabled 5 flaky failed 5 ( 24 mins, 12 secs ) stdio PRE_ThemeDataPackInvalid ThemeDataPackInvalid ContextMenusAPI_Basic Shim_TestNewWindow SpeechRecognitionAPI_HasPermissionDeny > Blink roll 174243:174291 > > http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=174243:174291&mode=html > TBR= > BUG= > > Review URL: https://codereview.chromium.org/291923002 TBR=eseidel@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271418

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M trunk/src/DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
ericu
6 years, 7 months ago (2014-05-19 17:59:00 UTC) #1
ericu
Committed patchset #1 manually as r271418 (tree was closed).
6 years, 7 months ago (2014-05-19 17:59:07 UTC) #2
ericu
Changed reviewer to timvolodine, the current gardener.
6 years, 7 months ago (2014-05-19 18:00:39 UTC) #3
eseidel
Please file a bug against the chromium CQ for failing to test whatever configuration this ...
6 years, 7 months ago (2014-05-19 18:02:27 UTC) #4
ericu
6 years, 7 months ago (2014-05-19 18:07:35 UTC) #5
Done.

On Mon, May 19, 2014 at 11:02 AM,  <eseidel@chromium.org> wrote:
> Please file a bug against the chromium CQ for failing to test whatever
> configuration this was that failed.  All blink rolls go through the Chromium
> CQ
> which shoudl be "safe".
>
> https://codereview.chromium.org/295703002/

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698