Issue 2957010: fix dhcpcd handling of Release dbus msg

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2957010: fix dhcpcd handling of Release dbus msg (Closed)

Created:
10 years, 5 months ago by Sam Leffler

Modified:
9 years, 7 months ago

Reviewers:
Nathan Williams

CC:
chromium-os-reviews_chromium.org

Base URL:
ssh://git@chromiumos-git//dhcpcd.git

Visibility:
Public.

Description

fix dhcpcd handling of Release dbus msg Don't stop the interface on Release; that clears state and exit's TEST=send Release and note the dhcpcd process exit's; apply fix and note it sticks around until flimflam tells it to terminate

Patch Set 1 #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -1 line)			Patch
	M	dhcpcd-dbus.c	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Sam Leffler

Looks like the previous CL didn't handle Release correctly; I believe this fixes the issue.

10 years, 5 months ago (2010-07-14 17:49:44 UTC) #1

LGTM.

Expand Messages | Collapse Messages