Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1260)

Unified Diff: chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/MainActivity.java

Issue 2956993002: Introduce a new WebAPK launch action. (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/MainActivity.java
diff --git a/chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/MainActivity.java b/chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/MainActivity.java
index 693cb384e5b99553502f4d6c03a657d502e3e931..16f3975e94a49d8b9186c16bad640ca4cfacec22 100644
--- a/chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/MainActivity.java
+++ b/chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/MainActivity.java
@@ -38,8 +38,8 @@ public class MainActivity extends Activity {
private static final String HOST_BROWSER_LAUNCHER_CLASS_NAME =
"org.chromium.webapk.lib.runtime_library.HostBrowserLauncher";
- // Action for launching {@link WebappLauncherActivity}. Must stay in sync with
- // {@link WebappLauncherActivity#ACTION_START_WEBAPP}.
+ // Action for launching {@link WebappLauncherActivity}. TODO(hanxi): Replaces this string with
Yaron 2017/06/27 14:38:24 We shouldn't update the shell apk version just for
Xi Han 2017/06/27 15:05:49 Thanks, add the NOPRESUBMIT=true to the CL descrip
+ // the new WebAPK launch action after it is propagated to all the Chrome's channels.
public static final String ACTION_START_WEBAPK =
"com.google.android.apps.chrome.webapps.WebappManager.ACTION_START_WEBAPP";

Powered by Google App Engine
This is Rietveld 408576698