Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(934)

Issue 2956883002: Handle continue and break in for-in and while loops (Closed)

Created:
3 years, 5 months ago by Johnni Winther
Modified:
3 years, 5 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Updated cf. comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -4 lines) Patch
M pkg/compiler/lib/src/kernel/kernel_backend_strategy.dart View 1 2 chunks +8 lines, -4 lines 0 comments Download
M tests/compiler/dart2js/kernel/compile_from_dill_test.dart View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
3 years, 5 months ago (2017-06-26 13:06:12 UTC) #2
Siggi Cherem (dart-lang)
lgtm, w/comments https://codereview.chromium.org/2956883002/diff/1/pkg/compiler/lib/src/kernel/kernel_backend_strategy.dart File pkg/compiler/lib/src/kernel/kernel_backend_strategy.dart (right): https://codereview.chromium.org/2956883002/diff/1/pkg/compiler/lib/src/kernel/kernel_backend_strategy.dart#newcode420 pkg/compiler/lib/src/kernel/kernel_backend_strategy.dart:420: node is ir.DoStatement; remove this `.parent` in ...
3 years, 5 months ago (2017-06-26 17:25:28 UTC) #3
Johnni Winther
https://codereview.chromium.org/2956883002/diff/1/pkg/compiler/lib/src/kernel/kernel_backend_strategy.dart File pkg/compiler/lib/src/kernel/kernel_backend_strategy.dart (right): https://codereview.chromium.org/2956883002/diff/1/pkg/compiler/lib/src/kernel/kernel_backend_strategy.dart#newcode420 pkg/compiler/lib/src/kernel/kernel_backend_strategy.dart:420: node is ir.DoStatement; On 2017/06/26 17:25:28, Siggi Cherem (dart-lang) ...
3 years, 5 months ago (2017-06-27 09:02:12 UTC) #4
Johnni Winther
3 years, 5 months ago (2017-06-27 09:07:25 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
7d026b538ea04685cb5bae36194df804f5f6b5fb (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698