Don't hide profile statistics counters with zero results

ui/login/account_picker/md_user_pod_row.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview User pod row implementation.
  */
 
 cr.define('login', function() {
   /**
@@ skipping 1823 matching lines @@
       for (var key in stats_elements) {
         if (this.user.statistics[key].success) {
           var count = this.user.statistics[key].count;
           stats_elements[key].textContent = count;
           total_count += count;
           num_stats_loaded++;
         }
       }
 
       // this.classList is used for selecting the appropriate dialog.
-      if (total_count)
-        this.classList.remove('has-no-stats');
+      this.classList.remove('has-no-stats');
 
       var is_synced_user = this.user.emailAddress !== "";
       // Write total number if all statistics are loaded.
       if (num_stats_loaded === Object.keys(stats_elements).length) {
         if (!total_count) {
-          this.classList.add('has-no-stats');
           var message = loadTimeData.getString(
               is_synced_user ? 'removeUserWarningTextSyncNoStats' :
                                'removeUserWarningTextNonSyncNoStats');
           this.updateRemoveWarningDialogSetMessage_(this.user.profilePath,
                                                     message);
         } else {
           window.updateRemoveWarningDialogSetMessage =
               this.updateRemoveWarningDialogSetMessage_.bind(this);
           chrome.send('getRemoveWarningDialogMessage',[{
               profilePath: this.user.profilePath,
@@ skipping 759 matching lines @@
 
       var isLockedUser = this.user.needsSignin;
       var isLegacySupervisedUser = this.user.legacySupervisedUser;
       var isChildUser = this.user.childUser;
       var isSyncedUser = this.user.emailAddress !== "";
       var isProfileLoaded = this.user.isProfileLoaded;
       this.classList.toggle('locked', isLockedUser);
       this.classList.toggle('legacy-supervised', isLegacySupervisedUser);
       this.classList.toggle('child', isChildUser);
       this.classList.toggle('synced', isSyncedUser);
       this.classList.toggle('has-no-stats',

[xiyuan, 2017/06/27 17:33:33]

Should we remove this too ?

[dullweber, 2017/06/28 09:39:44]

yes, we can probably remove has-no-stats completely. I changed the ProfileStats
to load the profile if required, so there is no case of not having stats
available anymore.

           !isProfileLoaded && !this.user.statistics.length);
 
       if (this.isAuthTypeUserClick)
         this.passwordLabelElement.textContent = this.authValue;
 
       this.passwordElement.setAttribute('aria-label', loadTimeData.getStringF(
         'passwordFieldAccessibleName', this.user_.emailAddress));
 
       UserPod.prototype.updateActionBoxArea.call(this);
     },
@@ skipping 925 matching lines @@
       for (var pod of pods) {
         pod.parentNode.removeChild(pod);
       }
       if (pods.length <= POD_ROW_LIMIT) {
         for (var pod of pods) {
           this.appendChild(pod);
         }
       } else {
         // When the user count exceeds the limit (currently set to 2), only the
         // main pod still has pow row as parent, all other pods should be
-        // appended to the container with scroll bar. 
+        // appended to the container with scroll bar.
         for (var pod of pods) {
           if (pod == this.mainPod_)
             this.appendChild(pod);
           else
             this.smallPodsContainer.appendChild(pod);
         }
       }
     },
 
     /**
@@ skipping 77 matching lines @@
       }
       // The size of the smallPodsContainer must be updated to avoid overflow.
       this.smallPodsContainer.style.height =
           cr.ui.toCssPx(this.screenSize.height);
       this.smallPodsContainer.style.width = cr.ui.toCssPx(CROS_SMALL_POD_WIDTH);
 
       var LEFT_PADDING = this.isPortraitMode_() ? 0 : 98;
       var MIDDLE_PADDING = this.isPortraitMode_() ? 84 : 220;
       var contentsWidth = LEFT_PADDING +
           CROS_POD_WIDTH + MIDDLE_PADDING + CROS_SMALL_POD_WIDTH;
-      var blankWidth = this.screenSize.width - contentsWidth;   
+      var blankWidth = this.screenSize.width - contentsWidth;
       var actualLeftPadding = LEFT_PADDING;
       actualLeftPadding +=
           this.isPortraitMode_() ? blankWidth * 2 / 3 : blankWidth / 2;
       var SMALL_POD_PADDING = 54;
       var actualSmallPodPadding = SMALL_POD_PADDING;
       var smallPodsTotalHeight = (pods.length - 1) * CROS_SMALL_POD_HEIGHT +
           (pods.length - 2) * actualSmallPodPadding;
 
       var SCROLL_TOP_PADDING = this.isPortraitMode_() ? 66 : 72;
       if (smallPodsTotalHeight + SCROLL_TOP_PADDING * 2 >
@@ skipping 11 matching lines @@
               (pods.length - 2) * actualSmallPodPadding;
         }
         // If virtual keyboard is not shown, or the updated total height still
         // exceeds screen height, fall to the scrollable container case.
         if (smallPodsTotalHeight + SCROLL_TOP_PADDING * 2 >
             this.screenSize.height) {
           this.placePodsOnScrollableContainer_();
           return;
         }
       }
-      
+
       // Start positioning of the main pod and the smallPodsContainer.
       this.mainPod_.left = actualLeftPadding;
-      this.mainPod_.top = (this.screenSize.height - CROS_POD_HEIGHT) / 2;   
+      this.mainPod_.top = (this.screenSize.height - CROS_POD_HEIGHT) / 2;
       this.smallPodsContainer.style.left =
           cr.ui.toCssPx(actualLeftPadding + CROS_POD_WIDTH + MIDDLE_PADDING);
       this.smallPodsContainer.style.top = cr.ui.toCssPx(0);
       // Start positioning of the small pods inside the smallPodsContainer.
       var smallPodsTopPadding =
           (this.screenSize.height - smallPodsTotalHeight) / 2;
       for (var pod of pods) {
         if (pod == this.mainPod_) {
           continue;
         }
@@ skipping 52 matching lines @@
       }
       scrollHeight -= EXTRA_SMALL_POD_PADDING;
       // The smallPodsContainer should occupy the full screen vertically.
       this.smallPodsContainer.style.height =
           cr.ui.toCssPx(this.screenSize.height);
       this.smallPodsContainer.style.width = cr.ui.toCssPx(
           SCROLL_LEFT_PADDING + CROS_EXTRA_SMALL_POD_WIDTH +
           SCROLL_RIGHT_PADDING);
 
       // SCROLL_TOP_PADDING denotes the smallest top padding we can tolerate
-      // before allowing the container to overflow and show the scroll bar.    
+      // before allowing the container to overflow and show the scroll bar.
       var actualTopPadding = SCROLL_TOP_PADDING;
       if ((this.screenSize.height - scrollHeight) / 2 > actualTopPadding) {
         // Edge case: the total height of the scrollable container does not
         // exceed the screen height (minus the neceesary padding), so the
         // scroll bar will not appear.
         // In this case, we still want to keep the extra small pod size and
         // the overlay, but the top and bottom padding should be adjusted
         // to ensure a symmetric layout.
         actualTopPadding = (this.screenSize.height - scrollHeight) / 2;
       } else if (!this.isScreenShrinked_()) {
         // The scroll bar will definitely be shown if we reach here. A gradient
         // mask is applied to avoid blocking the header bar if the virtual
         // keyboard is not shown. When the keyboard is shown, there's no need
-        // to add the mask and the original top padding value should be kept. 
+        // to add the mask and the original top padding value should be kept.
         actualTopPadding = SCROLL_MASK_HEIGHT;
         this.showScrollMask_();
-      } 
+      }
 
       // Start positioning of the small pods inside the smallPodsContainer.
       var topPadding = actualTopPadding;
       var lastPod = undefined;
       for (var pod of pods) {
         if (pod == this.mainPod_) {
           continue;
         }
         pod.left = SCROLL_LEFT_PADDING;
         pod.top = topPadding;
@@ skipping 280 matching lines @@
       // Add switch animation.
       this.mainPod_.smallPodImageElement.classList.add(
           'switch-image-animation');
       pod.imageElement.classList.add('switch-image-animation');
 
       // Switch parent and position of the two pods.
       var left = pod.left;
       var top = pod.top;
       // Edge case: paddingBottom should be switched too because there's a
       // chance that the small pod was at the end of the scrollable container
-      // and had a non-zero paddingBottom. 
+      // and had a non-zero paddingBottom.
       var paddingBottom = pod.style.paddingBottom;
       var parent = pod.parentNode;
       parent.removeChild(pod);
       this.appendChild(pod);
       pod.left = this.mainPod_.left;
       pod.top = this.mainPod_.top;
       pod.style.paddingBottom = cr.ui.toCssPx(0);
 
       this.removeChild(this.mainPod_);
       // It must have the same index with the original small pod, instead
@@ skipping 585 matching lines @@
       if (pod && pod.multiProfilesPolicyApplied) {
         pod.userTypeBubbleElement.classList.remove('bubble-shown');
       }
     }
   };
 
   return {
     PodRow: PodRow
   };
 });