Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Issue 295683002: Make javac.py output colorful (Closed)

Created:
6 years, 7 months ago by cjhopman
Modified:
5 years, 7 months ago
Reviewers:
Ted C, Nico
CC:
chromium-reviews, klundberg+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, nyquist
Visibility:
Public.

Description

Make javac.py output colorful This highlights warnings in yellow, errors in red(ish), and the ^ marker in blue. Adds stdout_filter and stderr_filter to build_utils.CheckOutput. If the caller handled this themselves they would need to print stdout/stderr themselves and modify the value stored in the ProcessCalledException. NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276231

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rebase + address comment #

Patch Set 3 : Rebase #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -2 lines) Patch
M build/android/gyp/javac.py View 1 3 chunks +44 lines, -1 line 1 comment Download
M build/android/gyp/util/build_utils.py View 1 3 chunks +15 lines, -1 line 0 comments Download

Messages

Total messages: 10 (1 generated)
cjhopman
tedchoc: *
6 years, 7 months ago (2014-05-19 18:04:37 UTC) #1
Ted C
lgtm https://codereview.chromium.org/295683002/diff/1/build/android/gyp/javac.py File build/android/gyp/javac.py (right): https://codereview.chromium.org/295683002/diff/1/build/android/gyp/javac.py#newcode24 build/android/gyp/javac.py:24: # ../base/android/java/src/org/chromium/base/library_loader/ProcessInitException.java:10: warning: [serial] serializable class org.chromium.base.library_loader.ProcessInitException has ...
6 years, 7 months ago (2014-05-19 23:56:52 UTC) #2
cjhopman
The CQ bit was checked by cjhopman@chromium.org
6 years, 6 months ago (2014-06-11 00:00:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cjhopman@chromium.org/295683002/40001
6 years, 6 months ago (2014-06-11 00:02:58 UTC) #4
cjhopman
The CQ bit was unchecked by cjhopman@chromium.org
6 years, 6 months ago (2014-06-11 01:52:02 UTC) #5
cjhopman
The CQ bit was checked by cjhopman@chromium.org
6 years, 6 months ago (2014-06-11 01:52:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cjhopman@chromium.org/295683002/40001
6 years, 6 months ago (2014-06-11 01:54:40 UTC) #7
commit-bot: I haz the power
Change committed as 276231
6 years, 6 months ago (2014-06-11 01:59:43 UTC) #8
Nico
5 years, 7 months ago (2015-05-24 23:32:17 UTC) #10
Message was sent while issue was closed.
https://codereview.chromium.org/295683002/diff/40001/build/android/gyp/javac.py
File build/android/gyp/javac.py (right):

https://codereview.chromium.org/295683002/diff/40001/build/android/gyp/javac....
build/android/gyp/javac.py:16: sys.path.append(build_utils.COLORAMA_ROOT)
FYI, you should always use `sys.path.insert(0, …`. Else if the user has a module
installed locally it will get precedence over the bundled one, and the installed
version might not be api-compatible with the bundled one.

Powered by Google App Engine
This is Rietveld 408576698