Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2881)

Unified Diff: chrome/browser/previews/previews_infobar_delegate.cc

Issue 2956733002: Add 'Updated just now' timestamp to the Previews infobar (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/previews/previews_infobar_delegate.cc
diff --git a/chrome/browser/previews/previews_infobar_delegate.cc b/chrome/browser/previews/previews_infobar_delegate.cc
index 3f87c2c00369300e95fc3a866299d3641b2b6010..14637c35feec46c1ced3b006ceacdf6d9e066e99 100644
--- a/chrome/browser/previews/previews_infobar_delegate.cc
+++ b/chrome/browser/previews/previews_infobar_delegate.cc
@@ -122,6 +122,7 @@ void PreviewsInfoBarDelegate::Create(
previews::PreviewsType previews_type,
base::Time previews_freshness,
bool is_data_saver_user,
+ bool is_reload,
const OnDismissPreviewsInfobarCallback& on_dismiss_callback) {
PreviewsInfoBarTabHelper* infobar_tab_helper =
PreviewsInfoBarTabHelper::FromWebContents(web_contents);
@@ -136,8 +137,8 @@ void PreviewsInfoBarDelegate::Create(
return;
std::unique_ptr<PreviewsInfoBarDelegate> delegate(new PreviewsInfoBarDelegate(
- web_contents, previews_type, previews_freshness, is_data_saver_user,
- on_dismiss_callback));
+ infobar_tab_helper, previews_type, previews_freshness, is_data_saver_user,
+ is_reload, on_dismiss_callback));
#if defined(OS_ANDROID)
std::unique_ptr<infobars::InfoBar> infobar_ptr(
@@ -163,14 +164,17 @@ void PreviewsInfoBarDelegate::Create(
}
PreviewsInfoBarDelegate::PreviewsInfoBarDelegate(
- content::WebContents* web_contents,
+ PreviewsInfoBarTabHelper* infobar_tab_helper,
previews::PreviewsType previews_type,
base::Time previews_freshness,
bool is_data_saver_user,
+ bool is_reload,
const OnDismissPreviewsInfobarCallback& on_dismiss_callback)
: ConfirmInfoBarDelegate(),
+ infobar_tab_helper_(infobar_tab_helper),
previews_type_(previews_type),
previews_freshness_(previews_freshness),
+ is_reload_(is_reload),
infobar_dismissed_action_(INFOBAR_DISMISSED_BY_TAB_CLOSURE),
message_text_(l10n_util::GetStringUTF16(
is_data_saver_user ? IDS_PREVIEWS_INFOBAR_SAVED_DATA_TITLE
@@ -283,6 +287,11 @@ base::string16 PreviewsInfoBarDelegate::GetTimestampText() const {
int staleness_in_minutes = (network_time - previews_freshness_).InMinutes();
if (staleness_in_minutes < min_staleness_in_minutes) {
+ if (is_reload_) {
+ RecordStaleness(TIMESTAMP_UPDATED_NOW_SHOWN);
+ return l10n_util::GetStringUTF16(
tbansal1 2017/06/23 23:24:08 consider adding: infobar_tab_helper_->set_displa
megjablon 2017/06/23 23:39:24 Done.
+ IDS_PREVIEWS_INFOBAR_TIMESTAMP_UPDATED_NOW);
+ }
RecordStaleness(TIMESTAMP_NOT_SHOWN_PREVIEW_NOT_STALE);
return base::string16();
}
@@ -292,6 +301,7 @@ base::string16 PreviewsInfoBarDelegate::GetTimestampText() const {
}
RecordStaleness(TIMESTAMP_SHOWN);
+ infobar_tab_helper_->set_displayed_preview_timestamp(true);
if (staleness_in_minutes < 60) {
return l10n_util::GetStringFUTF16(

Powered by Google App Engine
This is Rietveld 408576698