Issue 2956723002: Implement inference tests for logical operators.

Issue 2956723002: Implement inference tests for logical operators. (Closed)

Created:
3 years, 6 months ago by Paul Berry

Modified:
3 years, 6 months ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com

Target Ref:
refs/heads/master

Visibility:
Public.

Implement inference tests for logical operators. The tests for this are placed in inference_new because the analyzer implemenation doesn't do proper downward inference. R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/3b6f276c843f9d42d32d901627fe805b01a5ba5e

Created: 3 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+73 lines, -2 lines)			Patch
M	pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart	View	1 chunk	+8 lines, -2 lines	0 comments	Download
M	pkg/front_end/lib/src/fasta/type_inference/type_inference_listener.dart	View	1 chunk	+8 lines, -0 lines	0 comments	Download
A	pkg/front_end/testcases/inference_new/infer_logical.dart	View	1 chunk	+18 lines, -0 lines	0 comments	Download
A	pkg/front_end/testcases/inference_new/infer_logical.dart.direct.expect	View	1 chunk	+13 lines, -0 lines	0 comments	Download
A	pkg/front_end/testcases/inference_new/infer_logical.dart.outline.expect	View	1 chunk	+12 lines, -0 lines	0 comments	Download
A	pkg/front_end/testcases/inference_new/infer_logical.dart.strong.expect	View	1 chunk	+13 lines, -0 lines	0 comments	Download
M	pkg/front_end/testcases/kompile.status	View	1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 5 (2 generated)

Paul Berry

3 years, 6 months ago (2017-06-23 21:47:47 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
3b6f276c843f9d42d32d901627fe805b01a5ba5e (presubmit successful).