third_party/WebKit/public/platform/WebSurfaceLayerBridgeObserver.h - Issue 2956713003: Replaces VideoLayer with a SurfaceLayer in WebMediaPlayerImpl

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/public/platform/WebSurfaceLayerBridgeObserver.h

Issue 2956713003: Replaces VideoLayer with a SurfaceLayer in WebMediaPlayerImpl (Closed)

Patch Set: Replaces VideoLayer with SurfaceLayer. Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef WebSurfaceLayerBridgeObserver_h

	6 #define WebSurfaceLayerBridgeObserver_h

	7

	8 namespace blink {

	9

	10 class WebSurfaceLayerBridgeObserver {
	mlamouri (slow - plz ping) 2017/06/27 18:26:37 You might want to add some class level documentati You might want to add some class level documentation. CJ 2017/06/29 19:51:33 Done. Please check my wording. Show quoted text On 2017/06/27 18:26:37, mlamouri (slow) wrote: > You might want to add some class level documentation. Done. Please check my wording.
	11 public:

	12 WebSurfaceLayerBridgeObserver() {}
	mlamouri (slow - plz ping) 2017/06/27 18:26:37 Do you need the ctor here? Do you need the ctor here? CJ 2017/06/29 19:51:34 Done. Show quoted text On 2017/06/27 18:26:37, mlamouri (slow) wrote: > Do you need the ctor here? Done.
	13 virtual ~WebSurfaceLayerBridgeObserver() {}

	14

	15 virtual void OnWebLayerReplaced() = 0;

	16 };

	17

	18 } // namespace blink

	19

	20 #endif

OLD	NEW