Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Side by Side Diff: third_party/WebKit/Source/platform/graphics/SurfaceLayerBridge.cpp

Issue 2956713003: Replaces VideoLayer with a SurfaceLayer in WebMediaPlayerImpl (Closed)
Patch Set: Addresses comments #56-58. Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "platform/graphics/CanvasSurfaceLayerBridge.h" 5 #include "platform/graphics/SurfaceLayerBridge.h"
6 6
7 #include "cc/layers/layer.h" 7 #include "cc/layers/layer.h"
8 #include "cc/layers/solid_color_layer.h" 8 #include "cc/layers/solid_color_layer.h"
9 #include "cc/layers/surface_layer.h" 9 #include "cc/layers/surface_layer.h"
10 #include "cc/surfaces/sequence_surface_reference_factory.h" 10 #include "cc/surfaces/sequence_surface_reference_factory.h"
11 #include "cc/surfaces/surface_id.h" 11 #include "cc/surfaces/surface_id.h"
12 #include "cc/surfaces/surface_info.h" 12 #include "cc/surfaces/surface_info.h"
13 #include "cc/surfaces/surface_sequence.h" 13 #include "cc/surfaces/surface_sequence.h"
14 #include "platform/graphics/GraphicsLayer.h" 14 #include "platform/graphics/GraphicsLayer.h"
15 #include "platform/mojo/MojoHelper.h" 15 #include "platform/mojo/MojoHelper.h"
16 #include "platform/wtf/Functional.h" 16 #include "platform/wtf/Functional.h"
17 #include "public/platform/InterfaceProvider.h" 17 #include "public/platform/InterfaceProvider.h"
18 #include "public/platform/Platform.h" 18 #include "public/platform/Platform.h"
19 #include "public/platform/WebCompositorSupport.h" 19 #include "public/platform/WebCompositorSupport.h"
20 #include "public/platform/WebLayer.h" 20 #include "public/platform/WebLayer.h"
21 #include "public/platform/WebLayerTreeView.h" 21 #include "public/platform/WebLayerTreeView.h"
22 #include "public/platform/modules/offscreencanvas/offscreen_canvas_surface.mojom -blink.h" 22 #include "public/platform/modules/offscreencanvas/offscreen_canvas_surface.mojom -blink.h"
23 #include "ui/gfx/geometry/size.h" 23 #include "ui/gfx/geometry/size.h"
24 24
25 namespace blink { 25 namespace blink {
26 26
27 namespace { 27 namespace {
28 28 class SequenceSurfaceReferenceFactoryImpl
29 class OffscreenCanvasSurfaceReferenceFactory
30 : public cc::SequenceSurfaceReferenceFactory { 29 : public cc::SequenceSurfaceReferenceFactory {
31 public: 30 public:
32 OffscreenCanvasSurfaceReferenceFactory( 31 SequenceSurfaceReferenceFactoryImpl(base::WeakPtr<SurfaceLayerBridge> bridge)
33 base::WeakPtr<CanvasSurfaceLayerBridge> bridge)
34 : bridge_(bridge) {} 32 : bridge_(bridge) {}
35 33
36 private: 34 private:
37 ~OffscreenCanvasSurfaceReferenceFactory() override = default; 35 ~SequenceSurfaceReferenceFactoryImpl() override = default;
38 36
39 // cc::SequenceSurfaceReferenceFactory implementation: 37 // cc::SequenceSurfaceReferenceFactory implementation:
40 void RequireSequence(const cc::SurfaceId& id, 38 void RequireSequence(const cc::SurfaceId& id,
41 const cc::SurfaceSequence& sequence) const override { 39 const cc::SurfaceSequence& sequence) const override {
42 DCHECK(bridge_); 40 DCHECK(bridge_);
43 bridge_->RequireCallback(id, sequence); 41 bridge_->RequireCallback(id, sequence);
44 } 42 }
45 43
46 void SatisfySequence(const cc::SurfaceSequence& sequence) const override { 44 void SatisfySequence(const cc::SurfaceSequence& sequence) const override {
47 if (bridge_) 45 if (bridge_)
48 bridge_->SatisfyCallback(sequence); 46 bridge_->SatisfyCallback(sequence);
49 } 47 }
50 48
51 base::WeakPtr<CanvasSurfaceLayerBridge> bridge_; 49 base::WeakPtr<SurfaceLayerBridge> bridge_;
52 50
53 DISALLOW_COPY_AND_ASSIGN(OffscreenCanvasSurfaceReferenceFactory); 51 DISALLOW_COPY_AND_ASSIGN(SequenceSurfaceReferenceFactoryImpl);
54 }; 52 };
55 53
56 } // namespace 54 } // namespace
57 55
58 CanvasSurfaceLayerBridge::CanvasSurfaceLayerBridge( 56 SurfaceLayerBridge::SurfaceLayerBridge(SurfaceLayerBridgeObserver* observer,
59 CanvasSurfaceLayerBridgeObserver* observer, 57 WebLayerTreeView* layer_tree_view)
60 WebLayerTreeView* layer_tree_view)
61 : weak_factory_(this), 58 : weak_factory_(this),
62 observer_(observer), 59 observer_(observer),
63 binding_(this), 60 binding_(this),
64 frame_sink_id_(Platform::Current()->GenerateFrameSinkId()), 61 frame_sink_id_(Platform::Current()->GenerateFrameSinkId()),
65 parent_frame_sink_id_(layer_tree_view ? layer_tree_view->GetFrameSinkId() 62 parent_frame_sink_id_(layer_tree_view ? layer_tree_view->GetFrameSinkId()
66 : cc::FrameSinkId()) { 63 : cc::FrameSinkId()) {
67 ref_factory_ = 64 ref_factory_ =
68 new OffscreenCanvasSurfaceReferenceFactory(weak_factory_.GetWeakPtr()); 65 new SequenceSurfaceReferenceFactoryImpl(weak_factory_.GetWeakPtr());
69 66
70 DCHECK(!service_.is_bound()); 67 DCHECK(!service_.is_bound());
71 mojom::blink::OffscreenCanvasProviderPtr provider; 68 mojom::blink::OffscreenCanvasProviderPtr provider;
72 Platform::Current()->GetInterfaceProvider()->GetInterface( 69 Platform::Current()->GetInterfaceProvider()->GetInterface(
73 mojo::MakeRequest(&provider)); 70 mojo::MakeRequest(&provider));
74 // TODO(xlai): Ensure OffscreenCanvas commit() is still functional when a 71 // TODO(xlai): Ensure OffscreenCanvas commit() is still functional when a
75 // frame-less HTML canvas's document is reparenting under another frame. 72 // frame-less HTML canvas's document is reparenting under another frame.
76 // See crbug.com/683172. 73 // See crbug.com/683172.
77 blink::mojom::blink::OffscreenCanvasSurfaceClientPtr client; 74 blink::mojom::blink::OffscreenCanvasSurfaceClientPtr client;
78 binding_.Bind(mojo::MakeRequest(&client)); 75 binding_.Bind(mojo::MakeRequest(&client));
79 provider->CreateOffscreenCanvasSurface(parent_frame_sink_id_, frame_sink_id_, 76 provider->CreateOffscreenCanvasSurface(parent_frame_sink_id_, frame_sink_id_,
80 std::move(client), 77 std::move(client),
81 mojo::MakeRequest(&service_)); 78 mojo::MakeRequest(&service_));
82 } 79 }
83 80
84 CanvasSurfaceLayerBridge::~CanvasSurfaceLayerBridge() { 81 SurfaceLayerBridge::~SurfaceLayerBridge() {
85 observer_ = nullptr; 82 observer_ = nullptr;
86 if (web_layer_) { 83 if (web_layer_) {
87 GraphicsLayer::UnregisterContentsLayer(web_layer_.get()); 84 GraphicsLayer::UnregisterContentsLayer(web_layer_.get());
88 } 85 }
89 } 86 }
90 87
91 void CanvasSurfaceLayerBridge::CreateSolidColorLayer() { 88 void SurfaceLayerBridge::SatisfyCallback(const cc::SurfaceSequence& sequence) {
89 service_->Satisfy(sequence);
90 }
91
92 void SurfaceLayerBridge::RequireCallback(const cc::SurfaceId& surface_id,
93 const cc::SurfaceSequence& sequence) {
94 service_->Require(surface_id, sequence);
95 }
96
97 void SurfaceLayerBridge::CreateSolidColorLayer() {
92 cc_layer_ = cc::SolidColorLayer::Create(); 98 cc_layer_ = cc::SolidColorLayer::Create();
93 cc_layer_->SetBackgroundColor(SK_ColorTRANSPARENT); 99 cc_layer_->SetBackgroundColor(SK_ColorTRANSPARENT);
100
94 web_layer_ = Platform::Current()->CompositorSupport()->CreateLayerFromCCLayer( 101 web_layer_ = Platform::Current()->CompositorSupport()->CreateLayerFromCCLayer(
95 cc_layer_.get()); 102 cc_layer_.get());
96 GraphicsLayer::RegisterContentsLayer(web_layer_.get()); 103 GraphicsLayer::RegisterContentsLayer(web_layer_.get());
97 } 104 }
98 105
99 void CanvasSurfaceLayerBridge::OnSurfaceCreated( 106 void SurfaceLayerBridge::OnSurfaceCreated(const cc::SurfaceInfo& surface_info) {
100 const cc::SurfaceInfo& surface_info) {
101 if (!current_surface_id_.is_valid() && surface_info.is_valid()) { 107 if (!current_surface_id_.is_valid() && surface_info.is_valid()) {
102 // First time a SurfaceId is received 108 // First time a SurfaceId is received
103 current_surface_id_ = surface_info.id(); 109 current_surface_id_ = surface_info.id();
104 GraphicsLayer::UnregisterContentsLayer(web_layer_.get()); 110 GraphicsLayer::UnregisterContentsLayer(web_layer_.get());
105 web_layer_->RemoveFromParent(); 111 web_layer_->RemoveFromParent();
106 112
107 scoped_refptr<cc::SurfaceLayer> surface_layer = 113 scoped_refptr<cc::SurfaceLayer> surface_layer =
108 cc::SurfaceLayer::Create(ref_factory_); 114 cc::SurfaceLayer::Create(ref_factory_);
109 surface_layer->SetPrimarySurfaceInfo(surface_info); 115 surface_layer->SetPrimarySurfaceInfo(surface_info);
110 surface_layer->SetFallbackSurfaceInfo(surface_info); 116 surface_layer->SetFallbackSurfaceInfo(surface_info);
111 surface_layer->SetStretchContentToFillBounds(true); 117 surface_layer->SetStretchContentToFillBounds(true);
112 cc_layer_ = surface_layer; 118 cc_layer_ = surface_layer;
113 119
114 web_layer_ = 120 web_layer_ =
115 Platform::Current()->CompositorSupport()->CreateLayerFromCCLayer( 121 Platform::Current()->CompositorSupport()->CreateLayerFromCCLayer(
116 cc_layer_.get()); 122 cc_layer_.get());
117 GraphicsLayer::RegisterContentsLayer(web_layer_.get()); 123 GraphicsLayer::RegisterContentsLayer(web_layer_.get());
118 } else if (current_surface_id_ != surface_info.id()) { 124 } else if (current_surface_id_ != surface_info.id()) {
119 // A different SurfaceId is received, prompting change to existing 125 // A different SurfaceId is received, prompting change to existing
120 // SurfaceLayer 126 // SurfaceLayer
121 current_surface_id_ = surface_info.id(); 127 current_surface_id_ = surface_info.id();
122 cc::SurfaceLayer* surface_layer = 128 cc::SurfaceLayer* surface_layer =
123 static_cast<cc::SurfaceLayer*>(cc_layer_.get()); 129 static_cast<cc::SurfaceLayer*>(cc_layer_.get());
124 surface_layer->SetPrimarySurfaceInfo(surface_info); 130 surface_layer->SetPrimarySurfaceInfo(surface_info);
125 surface_layer->SetFallbackSurfaceInfo(surface_info); 131 surface_layer->SetFallbackSurfaceInfo(surface_info);
126 } 132 }
127 133
128 observer_->OnWebLayerReplaced(); 134 if (observer_)
135 observer_->OnWebLayerReplaced();
129 cc_layer_->SetBounds(surface_info.size_in_pixels()); 136 cc_layer_->SetBounds(surface_info.size_in_pixels());
130 } 137 }
131 138
132 void CanvasSurfaceLayerBridge::SatisfyCallback(
133 const cc::SurfaceSequence& sequence) {
134 service_->Satisfy(sequence);
135 }
136
137 void CanvasSurfaceLayerBridge::RequireCallback(
138 const cc::SurfaceId& surface_id,
139 const cc::SurfaceSequence& sequence) {
140 service_->Require(surface_id, sequence);
141 }
142
143 } // namespace blink 139 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/platform/graphics/SurfaceLayerBridge.h ('k') | third_party/WebKit/public/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698