Turn on rich editable text by default

chrome/browser/resources/chromeos/chromevox/cvox2/background/editing.js

Index: chrome/browser/resources/chromeos/chromevox/cvox2/background/editing.js
diff --git a/chrome/browser/resources/chromeos/chromevox/cvox2/background/editing.js b/chrome/browser/resources/chromeos/chromevox/cvox2/background/editing.js
index a679a41658593bf09f3116bb4c41ca6c0d9dbfde..e6f234cd0f05182c43750238295ea3f60a942d0e 100644
--- a/chrome/browser/resources/chromeos/chromevox/cvox2/background/editing.js
+++ b/chrome/browser/resources/chromeos/chromevox/cvox2/background/editing.js
@@ -45,7 +45,7 @@ editing.TextEditHandler = function(node) {
  * Flag set to indicate whether ChromeVox uses experimental rich text support.
  * @type {boolean}
  */
-editing.useRichText = false;
+editing.useRichText = true;
 
 editing.TextEditHandler.prototype = {
   /** @return {!AutomationNode} */
@@ -385,6 +385,21 @@ AutomationRichEditableText.prototype = {
     value.setSpan(new cvox.ValueSpan(0), 0, cur.value_.length);
     value.setSpan(
         new cvox.ValueSelectionSpan(), cur.startOffset, cur.endOffset);
+
+    // We might have to append labels for this text field if |cur| is the first
+    // line.
+    if (cur.localLineStartContainerOffset_ == 0 &&
+        cur.lineStartContainer_ ==
+            this.node_.find({role: RoleType.STATIC_TEXT})) {

[dmazzoni, 2017/06/23 18:36:01]

I think this assumes that the first static text is the
same as the first line, which isn't necessarily true.
You could have a contenteditable where the first "line"
is an image, then the next "line" is the first line of
a paragraph.

How about using a more general way to determine this is
the first line?

[David Tseng, 2017/06/23 18:44:28]

To be internally consistent with EditableLine, we would look for the first
inline text box to equal cur.lineStart_. Still doesn't address your concern
though and it also won't work at times because the inline text box gets
destroyed frequently. Do you have a generic way to know if a node can get
selection? The first leaf node is not really the answer I'm looking for.

+      value = new Spannable(value);
+      var labelComponents = [' '];
+      if (this.node_.name)
+        labelComponents.push(this.node_.name);
+      labelComponents.push(Msgs.getMsg('tag_textarea_brl'));
+      var label = labelComponents.join(' ');
+      value.append(label);
+    }
+
     cvox.ChromeVox.braille.write(new cvox.NavBraille(
         {text: value, startIndex: cur.startOffset, endIndex: cur.endOffset}));
   },