Turn on rich editable text by default

chrome/browser/resources/chromeos/chromevox/cvox2/background/editing.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview Processes events related to editing text and emits the
  * appropriate spoken and braille feedback.
  */
 
 goog.provide('editing.TextEditHandler');
@@ skipping 27 matching lines @@
  */
 editing.TextEditHandler = function(node) {
   /** @const {!AutomationNode} @private */
   this.node_ = node;
 };
 
 /**
  * Flag set to indicate whether ChromeVox uses experimental rich text support.
  * @type {boolean}
  */
-editing.useRichText = false;
+editing.useRichText = true;
 
 editing.TextEditHandler.prototype = {
   /** @return {!AutomationNode} */
   get node() {
     return this.node_;
   },
 
   /**
    * Receives the following kinds of events when the node provided to the
    * constructor is focuse: |focus|, |textChanged|, |textSelectionChanged| and
@@ skipping 319 matching lines @@
     }
   },
 
   /** @private */
   brailleCurrentRichLine_: function() {
     var cur = this.line_;
     var value = cur.value_;
     value.setSpan(new cvox.ValueSpan(0), 0, cur.value_.length);
     value.setSpan(
         new cvox.ValueSelectionSpan(), cur.startOffset, cur.endOffset);
+
+    // We might have to append labels for this text field if |cur| is the first
+    // line.
+    if (cur.localLineStartContainerOffset_ == 0 &&
+        cur.lineStartContainer_ ==
+            this.node_.find({role: RoleType.STATIC_TEXT})) {

[dmazzoni, 2017/06/23 18:36:01]

I think this assumes that the first static text is the
same as the first line, which isn't necessarily true.
You could have a contenteditable where the first "line"
is an image, then the next "line" is the first line of
a paragraph.

How about using a more general way to determine this is
the first line?

[David Tseng, 2017/06/23 18:44:28]

To be internally consistent with EditableLine, we would look for the first
inline text box to equal cur.lineStart_. Still doesn't address your concern
though and it also won't work at times because the inline text box gets
destroyed frequently. Do you have a generic way to know if a node can get
selection? The first leaf node is not really the answer I'm looking for.

+      value = new Spannable(value);
+      var labelComponents = [' '];
+      if (this.node_.name)
+        labelComponents.push(this.node_.name);
+      labelComponents.push(Msgs.getMsg('tag_textarea_brl'));
+      var label = labelComponents.join(' ');
+      value.append(label);
+    }
+
     cvox.ChromeVox.braille.write(new cvox.NavBraille(
         {text: value, startIndex: cur.startOffset, endIndex: cur.endOffset}));
   },
 
   /** @override */
   describeSelectionChanged: function(evt) {
     // Note that since Chrome allows for selection to be placed immediately at
     // the end of a line (i.e. end == value.length) and since we try to describe
     // the character to the right, this state has very little meaning in most
     // cases. Describe it as a new line. In braille, we simply show the cursor
@@ skipping 353 matching lines @@
    * @return {boolean}
    */
   isSameLineAndSelection: function(otherLine) {
     return this.isSameLine(otherLine) &&
         this.startOffset == otherLine.startOffset &&
         this.endOffset == otherLine.endOffset;
   }
 };
 
 });