Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(790)

Unified Diff: runtime/vm/intermediate_language.cc

Issue 2956653002: VM-codegen: For polymorphic methods don't expand Cids at call sites (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/intermediate_language.cc
diff --git a/runtime/vm/intermediate_language.cc b/runtime/vm/intermediate_language.cc
index 103e8fae3a5ff60a629b27de06fef2049b0c669f..39ca7386f69caeb7e11f402c492e48f39c18b5e1 100644
--- a/runtime/vm/intermediate_language.cc
+++ b/runtime/vm/intermediate_language.cc
@@ -2949,6 +2949,7 @@ CallTargets* CallTargets::CreateAndExpand(Zone* zone, const ICData& ic_data) {
for (int idx = 0; idx < length; idx++) {
int lower_limit_cid = (idx == 0) ? -1 : targets[idx - 1].cid_end;
const Function& target = *targets.TargetAt(idx)->target;
+ if (MethodRecognizer::PolymorphicTarget(target)) continue;
for (int i = targets[idx].cid_start - 1; i > lower_limit_cid; i--) {
if (FlowGraphCompiler::LookupMethodFor(i, name, args_desc, &fn) &&
fn.raw() == target.raw()) {
@@ -2964,6 +2965,7 @@ CallTargets* CallTargets::CreateAndExpand(Zone* zone, const ICData& ic_data) {
int upper_limit_cid =
(idx == length - 1) ? 1000000000 : targets[idx + 1].cid_start;
const Function& target = *targets.TargetAt(idx)->target;
+ if (MethodRecognizer::PolymorphicTarget(target)) continue;
for (int i = targets[idx].cid_end + 1; i < upper_limit_cid; i++) {
if (FlowGraphCompiler::LookupMethodFor(i, name, args_desc, &fn) &&
fn.raw() == target.raw()) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698