Retire JumpList favicon loading related UMA histograms

chrome/browser/win/jumplist.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/win/jumplist.h"
 
 #include "base/base_paths.h"
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/command_line.h"
@@ skipping 482 matching lines @@
   // When FaviconService has one, it will call OnFaviconDataAvailable().
   favicon::FaviconService* favicon_service =
       FaviconServiceFactory::GetForProfile(profile_,
                                            ServiceAccessType::EXPLICIT_ACCESS);
   // base::Unretained is safe since |this| is guaranteed to outlive
   // cancelable_task_tracker_.
   task_id_ = favicon_service->GetFaviconImageForPageURL(
       GURL(icon_urls_.front().first),
       base::Bind(&JumpList::OnFaviconDataAvailable, base::Unretained(this)),
       &cancelable_task_tracker_);
-
-  // TODO(chengx): Remove the UMA histogram after fixing http://crbug.com/717236
-  UMA_HISTOGRAM_TIMES("WinJumplist.StartLoadingFaviconDuration",
-                      timer.Elapsed());
 }
 
 void JumpList::OnFaviconDataAvailable(
     const favicon_base::FaviconImageResult& image_result) {
   DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
 
   base::ElapsedTimer timer;
 
   // If there is currently a favicon request in progress, it is now outdated,
   // as we have received another, so nullify the handle from the old request.
   task_id_ = base::CancelableTaskTracker::kBadTaskId;
 
   // Attach the received data to the ShellLinkItem object. This data will be
   // decoded by the RunUpdateJumpList method.
   if (!icon_urls_.empty()) {
     if (!image_result.image.IsEmpty() && icon_urls_.front().second.get()) {
       gfx::ImageSkia image_skia = image_result.image.AsImageSkia();
       image_skia.EnsureRepsForSupportedScales();
       std::unique_ptr<gfx::ImageSkia> deep_copy(image_skia.DeepCopy());
       icon_urls_.front().second->set_icon_image(*deep_copy);
     }
     icon_urls_.pop_front();
   }
 
-  // TODO(chengx): Remove the UMA histogram after fixing http://crbug.com/717236
-  UMA_HISTOGRAM_TIMES("WinJumplist.OnFaviconDataAvailableDuration",
-                      timer.Elapsed());
-
   // Check whether we need to load more favicons.
   StartLoadingFavicon();
 }
 
 void JumpList::PostRunUpdate() {
   DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
 
   TRACE_EVENT0("browser", "JumpList::PostRunUpdate");
 
   update_in_progress_ = true;
@@ skipping 277 matching lines @@
                                URLIconCache* icon_cache) {
   // Put all cached icon file paths into a set.
   base::flat_set<base::FilePath> cached_files;
   cached_files.reserve(icon_cache->size());
 
   for (const auto& url_path_pair : *icon_cache)
     cached_files.insert(url_path_pair.second);
 
   DeleteNonCachedFiles(icon_dir, cached_files);
 }