Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 2956493003: [Kernel] Add check in the constant evaluator. (Closed)

Created:
3 years, 6 months ago by jensj
Modified:
3 years, 5 months ago
Reviewers:
kustermann
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

[Kernel] Add check in the constant evaluator. Currently some tests pass in checked mode but fails in non-checked mode because we don't check the result of a constant-evaluation that should be bool in non-checked mode. This CL changes it so we always check the bool result in the constant-evaluator. BUG= R=kustermann@google.com Committed: https://github.com/dart-lang/sdk/commit/6cb702b723184ef8875871e4c15004d1ea0a8460

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -18 lines) Patch
M runtime/vm/kernel_binary_flowgraph.h View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/kernel_binary_flowgraph.cc View 1 chunk +1 line, -1 line 0 comments Download
M tests/co19/co19-kernel.status View 2 chunks +0 lines, -6 lines 0 comments Download
M tests/language/language_kernel.status View 2 chunks +0 lines, -9 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
jensj
3 years, 6 months ago (2017-06-23 11:14:05 UTC) #2
kustermann
lgtm
3 years, 6 months ago (2017-06-23 14:20:52 UTC) #3
jensj
3 years, 5 months ago (2017-06-29 09:18:17 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6cb702b723184ef8875871e4c15004d1ea0a8460 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698