Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Unified Diff: ios/chrome/browser/tabs/tab_helper_util.mm

Issue 2956483003: [ios] TabIdTabHelper (Closed)
Patch Set: Address comments. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/tabs/tab_helper_util.mm
diff --git a/ios/chrome/browser/tabs/tab_helper_util.mm b/ios/chrome/browser/tabs/tab_helper_util.mm
index e266138bd93bc80c74bbeca8983c41c0768956af..92f228e89ba301030d7ba96cd9355557bd3c2117 100644
--- a/ios/chrome/browser/tabs/tab_helper_util.mm
+++ b/ios/chrome/browser/tabs/tab_helper_util.mm
@@ -35,10 +35,13 @@
#import "ios/chrome/browser/web/network_activity_indicator_tab_helper.h"
#import "ios/chrome/browser/web/repost_form_tab_helper.h"
#import "ios/chrome/browser/web/sad_tab_tab_helper.h"
+#import "ios/chrome/browser/web/tab_id_tab_helper.h"
#import "ios/public/provider/chrome/browser/chrome_browser_provider.h"
#import "ios/web/public/web_state/web_state.h"
void AttachTabHelpers(web::WebState* web_state) {
+ // TabIDTabHelper provides the TabID, which is necessary in other helpers.
Eugene But (OOO till 7-30) 2017/06/23 22:44:56 nit: Does this comment add anything?
edchin 2017/06/26 16:20:57 Updated to be more specific.
+ TabIDTabHelper::CreateForWebState(web_state);
LegacyTabHelper::CreateForWebState(web_state);
Tab* tab = LegacyTabHelper::GetTabForWebState(web_state);
DCHECK(tab);
@@ -46,7 +49,7 @@ void AttachTabHelpers(web::WebState* web_state) {
ios::ChromeBrowserState* browser_state =
ios::ChromeBrowserState::FromBrowserState(web_state->GetBrowserState());
- // IOSChromeSessionTabHelper comes first because it sets up the tab ID,
+ // IOSChromeSessionTabHelper comes first because it sets up the session ID,
// and other helpers may rely on that.
IOSChromeSessionTabHelper::CreateForWebState(web_state);

Powered by Google App Engine
This is Rietveld 408576698