Settings: Network: Support choose mobile network

chrome/browser/resources/settings/internet_page/internet_detail_page.js

Index: chrome/browser/resources/settings/internet_page/internet_detail_page.js
diff --git a/chrome/browser/resources/settings/internet_page/internet_detail_page.js b/chrome/browser/resources/settings/internet_page/internet_detail_page.js
index ce8553d223b4e417441cc36678ed3c30df158512..0d6b538b34bada8375ccd6bbe72252a0d18d4701 100644
--- a/chrome/browser/resources/settings/internet_page/internet_detail_page.js
+++ b/chrome/browser/resources/settings/internet_page/internet_detail_page.js
@@ -615,6 +615,12 @@ Polymer({
     this.networkingPrivate.startActivate(this.guid);
   },
 
+  /** @private */
+  onChooseMobileTap_: function() {
+    // TODO(stevenjb): Integrate ChooseMobileNetworkDialog with WebUI.
+    chrome.send('addNetwork', [this.networkProperties.Type]);

[dpapad, 2017/06/22 18:54:50]

Drive by comment. Can you put chrome.send calls behind a proxy? This is the
pattern we used across Settings and makes testing much easier. Assuming
internet_detail_page has no tests, but that does not mean we should break our
JS/C++ browser proxy pattern here. 

[stevenjb, 2017/06/22 19:51:37]

No, it's not worth it, they will all be deprecated, thus the comment. I'm aware
of the pattern, I suggested it originally :)

+  },
+
   /** @const {string} */
   CR_EXPAND_BUTTON_TAG: 'CR-EXPAND-BUTTON',
 
@@ -969,16 +975,25 @@ Polymer({
     return this.isRememberedOrConnected_(networkProperties);
   },
 
+  /**
+   * @param {!CrOnc.NetworkProperties} networkProperties
+   * @return {boolean}
+   * @private
+   */
+  showCellularChooseNetwork_: function(networkProperties) {
+    return networkProperties.Type == CrOnc.Type.CELLULAR &&
+        !!this.get('Cellular.SupportNetworkScan', this.networkProperties);
+  },
+
   /**
    * @param {!CrOnc.NetworkProperties} networkProperties
    * @return {boolean}
    * @private
    */
   showCellularSim_: function(networkProperties) {
-    if (networkProperties.Type != 'Cellular' || !networkProperties.Cellular) {
-      return false;
-    }
-    return networkProperties.Cellular.Family == 'GSM';
+    return networkProperties.Type == CrOnc.Type.CELLULAR &&
+        this.get('Cellular.Family', this.networkProperties) ==
+        CrOnc.NetworkTechnology.GSM;
   },
 
   /**