Settings: Network: Support choose mobile network

chrome/browser/resources/settings/internet_page/internet_detail_page.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * 'settings-internet-detail' is the settings subpage containing details
  * for a network.
  */
 (function() {
@@ skipping 597 matching lines @@
     else
       chrome.send('configureNetwork', [this.guid]);
   },
 
   /** @private */
   onViewAccountTap_: function() {
     // startActivate() will show the account page for activated networks.
     this.networkingPrivate.startActivate(this.guid);
   },
 
+  /** @private */
+  onChooseMobileTap_: function() {
+    // TODO(stevenjb): Integrate ChooseMobileNetworkDialog with WebUI.
+    chrome.send('addNetwork', [this.networkProperties.Type]);

[dpapad, 2017/06/22 18:54:50]

Drive by comment. Can you put chrome.send calls behind a proxy? This is the
pattern we used across Settings and makes testing much easier. Assuming
internet_detail_page has no tests, but that does not mean we should break our
JS/C++ browser proxy pattern here. 

[stevenjb, 2017/06/22 19:51:37]

No, it's not worth it, they will all be deprecated, thus the comment. I'm aware
of the pattern, I suggested it originally :)

+  },
+
   /** @const {string} */
   CR_EXPAND_BUTTON_TAG: 'CR-EXPAND-BUTTON',
 
   /** @private */
   showTetherDialog_: function() {
     this.getTetherDialog_().open();
   },
 
   /**
    * @param {Event} event
@@ skipping 339 matching lines @@
     if (networkProperties.Type == CrOnc.Type.CELLULAR)
       return true;
     return this.isRememberedOrConnected_(networkProperties);
   },
 
   /**
    * @param {!CrOnc.NetworkProperties} networkProperties
    * @return {boolean}
    * @private
    */
-  showCellularSim_: function(networkProperties) {
-    if (networkProperties.Type != 'Cellular' || !networkProperties.Cellular) {
-      return false;
-    }
-    return networkProperties.Cellular.Family == 'GSM';
+  showCellularChooseNetwork_: function(networkProperties) {
+    return networkProperties.Type == CrOnc.Type.CELLULAR &&
+        !!this.get('Cellular.SupportNetworkScan', this.networkProperties);
   },
 
   /**
+   * @param {!CrOnc.NetworkProperties} networkProperties
+   * @return {boolean}
+   * @private
+   */
+  showCellularSim_: function(networkProperties) {
+    return networkProperties.Type == CrOnc.Type.CELLULAR &&
+        this.get('Cellular.Family', this.networkProperties) ==
+        CrOnc.NetworkTechnology.GSM;
+  },
+
+  /**
    * @param {!Object} curValue
    * @param {!Object} newValue
    * @return {boolean} True if all properties set in |newValue| are equal to
    *     the corresponding properties in |curValue|. Note: Not all properties
    *     of |curValue| need to be specified in |newValue| for this to return
    *     true.
    * @private
    */
   allPropertiesMatch_: function(curValue, newValue) {
     for (var key in newValue) {
       if (newValue[key] != curValue[key])
         return false;
     }
     return true;
   }
 });
 })();