Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Unified Diff: ios/chrome/browser/ui/payments/contact_info_edit_mediator.mm

Issue 2956433002: [Payment Request] keyboardType, autoCapitalizationType, etc for text fields (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/payments/contact_info_edit_mediator.mm
diff --git a/ios/chrome/browser/ui/payments/contact_info_edit_mediator.mm b/ios/chrome/browser/ui/payments/contact_info_edit_mediator.mm
index 98e20b8d9f0714de23ded9be8bd94cc50457c559..0649a8bb587fd0a2dd66487cef338a08aa8d6032 100644
--- a/ios/chrome/browser/ui/payments/contact_info_edit_mediator.mm
+++ b/ios/chrome/browser/ui/payments/contact_info_edit_mediator.mm
@@ -107,6 +107,10 @@
IDS_PAYMENTS_NAME_FIELD_IN_CONTACT_DETAILS)
value:name
required:YES];
+ if (!_paymentRequest->request_payer_phone() &&
+ !_paymentRequest->request_payer_email()) {
+ nameField.returnKeyType = UIReturnKeyDone;
+ }
[self.fields addObject:nameField];
}
@@ -125,6 +129,9 @@
IDS_PAYMENTS_PHONE_FIELD_IN_CONTACT_DETAILS)
value:phone
required:YES];
+ phoneField.keyboardType = UIKeyboardTypePhonePad;
+ if (!_paymentRequest->request_payer_email())
+ phoneField.returnKeyType = UIReturnKeyDone;
[self.fields addObject:phoneField];
}
@@ -138,6 +145,9 @@
IDS_PAYMENTS_EMAIL_FIELD_IN_CONTACT_DETAILS)
value:email
required:YES];
+ emailField.keyboardType = UIKeyboardTypeEmailAddress;
+ emailField.autoCapitalizationType = UITextAutocapitalizationTypeNone;
+ emailField.returnKeyType = UIReturnKeyDone;
[self.fields addObject:emailField];
}
« no previous file with comments | « ios/chrome/browser/ui/payments/address_edit_mediator.mm ('k') | ios/chrome/browser/ui/payments/credit_card_edit_mediator.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698