[DevTools] Provide Target.targetInfoChanged notification

third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js

 /*
  * Copyright 2014 The Chromium Authors. All rights reserved.
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 SDK.TargetManager = class extends Common.Object {
   constructor() {
     super();
     /** @type {!Array.<!SDK.Target>} */
@@ skipping 472 matching lines @@
   }
 
   /**
    * @override
    * @param {!Protocol.Target.TargetInfo} targetInfo
    */
   targetCreated(targetInfo) {
     if (targetInfo.type !== 'node')
       return;
     if (Runtime.queryParam('nodeFrontend')) {
-      this._targetAgent.attachToTarget(targetInfo.targetId);
-    } else {
-      this._targetManager._nodeTargetIds.add(targetInfo.targetId);
+      if (!targetInfo.attached)

[caseq, 2017/06/29 20:36:17]

This is still prone to races. So perhaps try attaching anyway?

[dgozman, 2017/06/29 21:31:23]

Acknowledged.

+        this._targetAgent.attachToTarget(targetInfo.targetId);
+      return;
+    }
+    if (targetInfo.attached)
+      return;
+    this._targetManager._nodeTargetIds.add(targetInfo.targetId);
+    this._targetManager.dispatchEventToListeners(SDK.TargetManager.Events.AvailableNodeTargetsChanged);
+  }
+
+  /**
+   * @override
+   * @param {!Protocol.Target.TargetInfo} targetInfo
+   */
+  targetInfoChanged(targetInfo) {
+    if (targetInfo.type !== 'node' || Runtime.queryParam('nodeFrontend'))
+      return;
+    var availableIds = this._targetManager._nodeTargetIds;
+    if (!availableIds.has(targetInfo.targetId) && !targetInfo.attached) {
+      availableIds.add(targetInfo.targetId);
+      this._targetManager.dispatchEventToListeners(SDK.TargetManager.Events.AvailableNodeTargetsChanged);
+    } else if (availableIds.has(targetInfo.targetId) && targetInfo.attached) {
+      availableIds.delete(targetInfo.targetId);
       this._targetManager.dispatchEventToListeners(SDK.TargetManager.Events.AvailableNodeTargetsChanged);
     }
   }
 
   /**
    * @override
    * @param {string} targetId
    */
   targetDestroyed(targetId) {
     if (Runtime.queryParam('nodeFrontend') || !this._targetManager._nodeTargetIds.has(targetId))
@@ skipping 138 matching lines @@
   /**
    * @param {!T} model
    */
   modelRemoved(model) {},
 };
 
 /**
  * @type {!SDK.TargetManager}
  */
 SDK.targetManager = new SDK.TargetManager();