Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2956353002: Add a mixin for assists similar to that for fixes (Closed)

Created:
3 years, 5 months ago by Brian Wilkerson
Modified:
3 years, 5 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -35 lines) Patch
M pkg/analysis_server/lib/plugin/edit/assist/assist_core.dart View 3 chunks +2 lines, -35 lines 0 comments Download
M pkg/analysis_server/lib/src/services/correction/assist.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/services/correction/assist_internal.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/services/correction/assist_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer_plugin/lib/utilities/assist/assist.dart View 1 chunk +36 lines, -0 lines 0 comments Download
A pkg/analyzer_plugin/lib/utilities/assist/assist_contributor_mixin.dart View 1 chunk +40 lines, -0 lines 2 comments Download

Messages

Total messages: 6 (2 generated)
Brian Wilkerson
3 years, 5 months ago (2017-06-28 18:25:34 UTC) #2
scheglov
LGTM https://codereview.chromium.org/2956353002/diff/1/pkg/analyzer_plugin/lib/utilities/assist/assist_contributor_mixin.dart File pkg/analyzer_plugin/lib/utilities/assist/assist_contributor_mixin.dart (right): https://codereview.chromium.org/2956353002/diff/1/pkg/analyzer_plugin/lib/utilities/assist/assist_contributor_mixin.dart#newcode31 pkg/analyzer_plugin/lib/utilities/assist/assist_contributor_mixin.dart:31: {List args: null}) { `null` is the default ...
3 years, 5 months ago (2017-06-28 18:36:33 UTC) #3
Brian Wilkerson
https://codereview.chromium.org/2956353002/diff/1/pkg/analyzer_plugin/lib/utilities/assist/assist_contributor_mixin.dart File pkg/analyzer_plugin/lib/utilities/assist/assist_contributor_mixin.dart (right): https://codereview.chromium.org/2956353002/diff/1/pkg/analyzer_plugin/lib/utilities/assist/assist_contributor_mixin.dart#newcode31 pkg/analyzer_plugin/lib/utilities/assist/assist_contributor_mixin.dart:31: {List args: null}) { Removed
3 years, 5 months ago (2017-06-28 18:43:49 UTC) #4
Brian Wilkerson
3 years, 5 months ago (2017-06-28 18:44:27 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7bd9e6c443ebfbb59f5e558bce62dea5314d0ecb (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698